You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by pe...@apache.org on 2021/12/14 07:44:12 UTC
[pulsar] branch master updated: Fix master broken, duplicate test methods (#13279)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 01c5f89 Fix master broken, duplicate test methods (#13279)
01c5f89 is described below
commit 01c5f89df03b8924e569ff51c60c78c3e315f24b
Author: ZhangJian He <sh...@gmail.com>
AuthorDate: Tue Dec 14 15:43:07 2021 +0800
Fix master broken, duplicate test methods (#13279)
---
.../pulsar/functions/utils/SinkConfigUtilsTest.java | 21 +--------------------
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/pulsar-functions/utils/src/test/java/org/apache/pulsar/functions/utils/SinkConfigUtilsTest.java b/pulsar-functions/utils/src/test/java/org/apache/pulsar/functions/utils/SinkConfigUtilsTest.java
index 398790e..2a2560c 100644
--- a/pulsar-functions/utils/src/test/java/org/apache/pulsar/functions/utils/SinkConfigUtilsTest.java
+++ b/pulsar-functions/utils/src/test/java/org/apache/pulsar/functions/utils/SinkConfigUtilsTest.java
@@ -364,10 +364,7 @@ public class SinkConfigUtilsTest extends PowerMockTestCase {
SinkConfig sinkConfig = createSinkConfig();
SinkConfig newSinkConfig = createUpdatedSinkConfig("cleanupSubscription", false);
SinkConfig mergedConfig = SinkConfigUtils.validateUpdate(sinkConfig, newSinkConfig);
- assertEquals(
- mergedConfig.getCleanupSubscription().booleanValue(),
- false
- );
+ assertFalse(mergedConfig.getCleanupSubscription());
mergedConfig.setCleanupSubscription(sinkConfig.getCleanupSubscription());
assertEquals(
new Gson().toJson(sinkConfig),
@@ -391,22 +388,6 @@ public class SinkConfigUtilsTest extends PowerMockTestCase {
}
@Test
- public void testMergeDifferentCleanupSubscription() {
- SinkConfig sinkConfig = createSinkConfig();
- SinkConfig newSinkConfig = createUpdatedSinkConfig("cleanupSubscription", false);
- SinkConfig mergedConfig = SinkConfigUtils.validateUpdate(sinkConfig, newSinkConfig);
- assertEquals(
- mergedConfig.getCleanupSubscription().booleanValue(),
- false
- );
- mergedConfig.setCleanupSubscription(sinkConfig.getCleanupSubscription());
- assertEquals(
- new Gson().toJson(sinkConfig),
- new Gson().toJson(mergedConfig)
- );
- }
-
- @Test
public void testValidateConfig() throws IOException {
mockStatic(ConnectorUtils.class);
mockStatic(NarUnpacker.class);