You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/08 11:14:30 UTC
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4662: Feat/ram reservation
DaanHoogland commented on a change in pull request #4662:
URL: https://github.com/apache/cloudstack/pull/4662#discussion_r571964241
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java
##########
@@ -549,12 +549,6 @@ public static void setBasicVmConfig(VirtualMachineConfigSpec vmConfig, int cpuCo
cpuInfo.setReservation((long)cpuReservedMhz);
vmConfig.setCpuAllocation(cpuInfo);
- if (cpuSpeedMHz != cpuReservedMhz) {
- vmConfig.setCpuHotAddEnabled(true);
- }
- if (memoryMB != memoryReserveMB) {
- vmConfig.setMemoryHotAddEnabled(true);
- }
Review comment:
thsi removal does not seem relevant to your feature description. can you explain @DK101010 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org