[GitHub] houshengbo commented on a change in pull request #541: Add strict flag for user defined runtime.

[gi...@git.apache.org]

houshengbo commented on a change in pull request #541: Add strict flag for user defined runtime.
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/541#discussion_r140678012
 
 

 ##########
 File path: parsers/manifest_parser.go
 ##########
 @@ -389,14 +389,14 @@ func (dm *YAMLParser) ComposeActions(filePath string, actions map[string]Action,
 		if action.Runtime != "" {
 			if utils.CheckExistRuntime(action.Runtime, utils.Rts) {
 				wskaction.Exec.Kind = action.Runtime
-			} else {
-				errStr := wski18n.T("the runtime is not supported by Openwhisk platform.\n")
-				whisk.Debug(whisk.DbgWarn, errStr)
-			}
-		} else {
-			errStr := wski18n.T("wskdeploy has chosen a particular runtime for the action.\n")
-			whisk.Debug(whisk.DbgWarn, errStr)
-		}
+
+			} else if utils.Flags.Strict {
+                wskaction.Exec.Kind = action.Runtime
+            } else {
+                errStr := wski18n.T("wskdeploy has chosen a particular runtime for the action.\n")
 
 Review comment:
   This message should be added into json file as the i18n string. After that, i18n_resources should be regenerated.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services