You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by alfonsonishikawa <gi...@git.apache.org> on 2018/01/10 20:12:43 UTC
[GitHub] gora pull request #126: Setting dirty with value -1 (11111111b) instead of -...
GitHub user alfonsonishikawa opened a pull request:
https://github.com/apache/gora/pull/126
Setting dirty with value -1 (11111111b) instead of -128(1000000b) whe…
…n calling setDirty().
Omited tests since the change is trivial.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alfonsonishikawa/gora GORA-421
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit 546a1c7d5d40f45e7ce2331255c1763a5b04579e
Author: Alfonso Nishikawa Muñumer <al...@...>
Date: 2018-01-10T20:06:25Z
Setting dirty with value -1 (11111111b) instead of -128(1000000b) when calling setDirty()
----
---
[GitHub] gora issue #126: Setting dirty with value -1 (11111111b) instead of -128(100...
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/gora/pull/126
Any test?
---
[GitHub] gora issue #126: Setting dirty with value -1 (11111111b) instead of -128(100...
Posted by alfonsonishikawa <gi...@git.apache.org>.
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/126
Updated with the test :) Thanks for the feedback.
---
[GitHub] gora issue #126: Setting dirty with value -1 (11111111b) instead of -128(100...
Posted by alfonsonishikawa <gi...@git.apache.org>.
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/126
Fix for GORA-421 https://issues.apache.org/jira/browse/GORA-421
---
[GitHub] gora issue #126: Setting dirty with value -1 (11111111b) instead of -128(100...
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/gora/pull/126
+1 LGTM
---
[GitHub] gora pull request #126: Setting dirty with value -1 (11111111b) instead of -...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/126
---
[GitHub] gora issue #126: Setting dirty with value -1 (11111111b) instead of -128(100...
Posted by alfonsonishikawa <gi...@git.apache.org>.
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/126
For once I assumed it was too trivial for a test... ;)
I am working on it.
I noticed that maybe someone sometime would need a "setDirty" that sets dirty deep in the hierarchical data, and not only the shallow fields. But this is not the issue :)
---