You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "liutang123 (via GitHub)" <gi...@apache.org> on 2025/10/16 03:24:13 UTC
[PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
liutang123 opened a new pull request, #57022:
URL: https://github.com/apache/doris/pull/57022
pick from master #52667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3420391736
<details>
<summary>TPC-H: <b>Total hot run time: 39790 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 06fbafbb85840e4aa6f12eb752d920aed43c2c51, data reload: false
------ Round 1 ----------------------------------
q1 17579 6877 6621 6621
q2 2046 217 175 175
q3 10656 1134 1186 1134
q4 10503 726 691 691
q5 7750 2827 2786 2786
q6 218 131 132 131
q7 975 629 607 607
q8 9389 1922 1968 1922
q9 6660 6386 6399 6386
q10 7008 2285 2313 2285
q11 457 265 256 256
q12 449 212 216 212
q13 17807 2972 3006 2972
q14 229 213 216 213
q15 525 471 458 458
q16 486 378 366 366
q17 973 634 639 634
q18 7128 6515 6766 6515
q19 1431 1143 1073 1073
q20 441 194 199 194
q21 4131 3249 3153 3153
q22 1103 1023 1006 1006
Total cold run time: 107944 ms
Total hot run time: 39790 ms
----- Round 2, with runtime_filter_mode=off -----
q1 6620 6598 6631 6598
q2 325 236 231 231
q3 2912 2970 2912 2912
q4 2010 1862 1781 1781
q5 5744 5754 5728 5728
q6 216 130 128 128
q7 2240 1767 1812 1767
q8 3429 3550 3598 3550
q9 8846 8937 8876 8876
q10 3582 3528 3566 3528
q11 588 500 490 490
q12 794 583 612 583
q13 8915 3200 3176 3176
q14 299 266 277 266
q15 507 465 474 465
q16 479 427 455 427
q17 1839 1644 1655 1644
q18 8287 7726 7729 7726
q19 1656 1402 1457 1402
q20 2127 1862 1930 1862
q21 5220 5114 5028 5028
q22 1136 1092 1051 1051
Total cold run time: 67771 ms
Total hot run time: 59219 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on code in PR #57022:
URL: https://github.com/apache/doris/pull/57022#discussion_r2458429540
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/SubqueryToApply.java:
##########
@@ -398,76 +395,63 @@ private static boolean hasTopLevelScalarAgg(Plan plan) {
return false;
}
- private Pair<LogicalPlan, Optional<Expression>> addApply(SubqueryExpr subquery,
- LogicalPlan childPlan,
+ private Pair<LogicalPlan, Optional<Expression>> addApply(SubqueryExpr subquery, LogicalPlan childPlan,
Map<SubqueryExpr, Optional<MarkJoinSlotReference>> subqueryToMarkJoinSlot,
- CascadesContext ctx, Optional<Expression> conjunct, boolean isProject,
- boolean singleSubquery, boolean isMarkJoinSlotNotNull) {
+ CascadesContext ctx, Optional<Expression> correlatedOuterExpr, boolean isMarkJoinSlotNotNull) {
ctx.setSubqueryExprIsAnalyzed(subquery, true);
Optional<MarkJoinSlotReference> markJoinSlot = subqueryToMarkJoinSlot.get(subquery);
- boolean needAddScalarSubqueryOutputToProjects = isConjunctContainsScalarSubqueryOutput(
- subquery, conjunct, isProject, singleSubquery);
+
+ boolean needAddScalarSubqueryOutputToProjects = isScalarSubqueryOutputUsedInOuterScope(
+ subquery, correlatedOuterExpr);
boolean needRuntimeAssertCount = false;
- NamedExpression oldSubqueryOutput = subquery.getQueryPlan().getOutput().get(0);
+ // In #50256, needRuntimeAssertCount has been replaced by needRuntimeAnyValue
+ // for scalar subquery, we need ensure it output at most 1 row
+ // by doing that, we add an aggregate function any_value() to the project list
+ // we use needRuntimeAnyValue to indicate if any_value() is needed
+ // if needRuntimeAnyValue is true, we will add it to the project list
+ // boolean needRuntimeAnyValue = false;
+ NamedExpression subqueryOutput = subquery.getQueryPlan().getOutput().get(0);
+ // if (subquery instanceof ScalarSubquery) { // #51928
Review Comment:
remove these comment, and please check if need to pick https://github.com/apache/doris/pull/51928 after this one is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3410057371
<details>
<summary>TPC-DS: <b>Total hot run time: 193612 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 95591368cdc23cb35eb3bfed7f1933049aa5167e, data reload: false
query1 950 404 396 396
query2 6266 1977 1931 1931
query3 8676 209 198 198
query4 33688 23562 23944 23562
query5 3739 483 471 471
query6 292 178 177 177
query7 4199 315 330 315
query8 303 223 259 223
query9 9336 2605 2601 2601
query10 447 279 274 274
query11 18212 15340 15177 15177
query12 159 103 106 103
query13 1567 447 431 431
query14 9888 7475 7716 7475
query15 255 183 188 183
query16 8103 500 460 460
query17 1670 613 595 595
query18 2150 344 325 325
query19 384 159 164 159
query20 123 121 119 119
query21 208 109 123 109
query22 4764 4365 4448 4365
query23 35172 34616 34185 34185
query24 11849 3007 2936 2936
query25 709 430 435 430
query26 1755 176 187 176
query27 2696 358 370 358
query28 7554 2211 2203 2203
query29 1061 475 473 473
query30 272 180 163 163
query31 1067 838 811 811
query32 104 60 63 60
query33 795 344 317 317
query34 1134 542 535 535
query35 931 740 744 740
query36 1127 967 955 955
query37 265 71 71 71
query38 4148 3946 3953 3946
query39 1509 1464 1499 1464
query40 259 108 102 102
query41 51 48 49 48
query42 121 101 101 101
query43 539 502 500 500
query44 1347 834 850 834
query45 192 184 175 175
query46 1175 738 770 738
query47 2035 1892 1903 1892
query48 496 394 405 394
query49 1034 409 423 409
query50 820 431 434 431
query51 7433 7312 7196 7196
query52 103 91 95 91
query53 271 197 198 197
query54 1183 466 484 466
query55 77 81 83 81
query56 270 258 263 258
query57 1328 1215 1188 1188
query58 237 224 230 224
query59 3348 3061 3029 3029
query60 290 265 286 265
query61 118 125 112 112
query62 859 703 702 702
query63 242 218 211 211
query64 5010 692 642 642
query65 3393 3356 3316 3316
query66 1297 305 318 305
query67 16280 15553 15562 15553
query68 5498 577 573 573
query69 435 263 269 263
query70 1185 1131 1126 1126
query71 348 270 263 263
query72 6259 4013 4144 4013
query73 753 353 352 352
query74 10524 8922 9218 8922
query75 3398 2650 2652 2650
query76 3338 1052 1076 1052
query77 397 281 296 281
query78 10479 9691 9593 9593
query79 2479 631 635 631
query80 1119 444 439 439
query81 547 219 225 219
query82 592 95 97 95
query83 228 148 148 148
query84 238 79 76 76
query85 1709 328 303 303
query86 490 303 294 294
query87 4366 4323 4283 4283
query88 4306 2400 2364 2364
query89 410 298 292 292
query90 2078 190 190 190
query91 195 157 156 156
query92 66 50 50 50
query93 2435 566 573 566
query94 951 308 305 305
query95 383 253 255 253
query96 607 285 280 280
query97 3393 3157 3125 3125
query98 219 207 199 199
query99 1489 1324 1335 1324
Total cold run time: 308249 ms
Total hot run time: 193612 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3410700908
# FE UT Coverage Report
Increment line coverage ` 78.08% (57/73)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57022_e134512d574fa2d3558b6a4d4246af8d833bf7e4/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57022_e134512d574fa2d3558b6a4d4246af8d833bf7e4/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3410002879
<details>
<summary>TPC-H: <b>Total hot run time: 40087 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 95591368cdc23cb35eb3bfed7f1933049aa5167e, data reload: false
------ Round 1 ----------------------------------
q1 17588 6936 6721 6721
q2 2042 183 163 163
q3 10624 1171 1184 1171
q4 10567 734 723 723
q5 7735 2870 2831 2831
q6 207 131 133 131
q7 958 619 604 604
q8 9586 1956 2001 1956
q9 8132 6408 6426 6408
q10 7037 2261 2244 2244
q11 459 253 260 253
q12 403 215 217 215
q13 17780 3021 3008 3008
q14 235 208 218 208
q15 511 466 466 466
q16 477 375 374 374
q17 976 506 583 506
q18 7392 6703 6782 6703
q19 1412 1079 1172 1079
q20 475 194 200 194
q21 3887 3150 3320 3150
q22 1121 1035 979 979
Total cold run time: 109604 ms
Total hot run time: 40087 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7155 6600 6604 6600
q2 328 238 230 230
q3 3044 2952 2927 2927
q4 2062 1800 1801 1800
q5 5746 5775 5726 5726
q6 217 133 135 133
q7 2209 1812 1836 1812
q8 3357 3566 3481 3481
q9 8946 8953 8900 8900
q10 3585 3545 3561 3545
q11 593 485 498 485
q12 805 599 605 599
q13 6700 3153 3192 3153
q14 302 274 258 258
q15 525 476 460 460
q16 496 454 456 454
q17 1856 1653 1621 1621
q18 8335 7751 7810 7751
q19 1645 1475 1586 1475
q20 2088 1889 1888 1888
q21 5332 5202 5031 5031
q22 1137 1069 1015 1015
Total cold run time: 66463 ms
Total hot run time: 59344 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3410075178
<details>
<summary>ClickBench: <b>Total hot run time: 29.16 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 95591368cdc23cb35eb3bfed7f1933049aa5167e, data reload: false
query1 0.03 0.03 0.03
query2 0.07 0.03 0.03
query3 0.24 0.07 0.06
query4 1.63 0.10 0.10
query5 0.53 0.54 0.53
query6 1.13 0.72 0.73
query7 0.02 0.02 0.02
query8 0.05 0.03 0.04
query9 0.57 0.50 0.52
query10 0.55 0.54 0.55
query11 0.14 0.09 0.10
query12 0.13 0.11 0.11
query13 0.60 0.60 0.58
query14 0.76 0.79 0.79
query15 0.85 0.83 0.82
query16 0.40 0.39 0.41
query17 1.06 1.06 1.07
query18 0.24 0.22 0.22
query19 1.93 1.89 1.71
query20 0.01 0.01 0.01
query21 15.41 0.58 0.59
query22 2.20 2.45 1.27
query23 16.97 0.94 0.81
query24 3.14 0.97 0.38
query25 0.23 0.28 0.18
query26 0.24 0.13 0.13
query27 0.03 0.04 0.05
query28 11.12 0.47 0.51
query29 12.59 3.23 3.22
query30 0.25 0.06 0.06
query31 2.85 0.40 0.37
query32 3.25 0.46 0.46
query33 2.99 3.04 3.06
query34 16.81 4.57 4.53
query35 4.54 4.52 4.58
query36 0.66 0.47 0.47
query37 0.08 0.06 0.06
query38 0.04 0.03 0.03
query39 0.03 0.02 0.02
query40 0.15 0.12 0.12
query41 0.07 0.02 0.02
query42 0.03 0.02 0.02
query43 0.04 0.02 0.02
Total cold run time: 104.66 s
Total hot run time: 29.16 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3421640985
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3430247943
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3449254400
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3449254476
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3410526408
<details>
<summary>TPC-DS: <b>Total hot run time: 192235 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e134512d574fa2d3558b6a4d4246af8d833bf7e4, data reload: false
query1 954 425 408 408
query2 6202 1951 1912 1912
query3 8677 200 197 197
query4 33754 24116 23396 23396
query5 3849 458 437 437
query6 295 182 193 182
query7 4208 312 322 312
query8 292 217 217 217
query9 9267 2581 2584 2581
query10 481 262 270 262
query11 18062 15154 15194 15154
query12 157 100 99 99
query13 1563 437 425 425
query14 9844 7003 6975 6975
query15 240 176 176 176
query16 8026 514 523 514
query17 1670 628 591 591
query18 2124 328 325 325
query19 255 167 169 167
query20 124 113 114 113
query21 218 109 110 109
query22 4785 4505 4497 4497
query23 35075 34420 33883 33883
query24 12033 2993 2954 2954
query25 678 429 443 429
query26 1785 172 175 172
query27 2944 366 384 366
query28 7740 2191 2172 2172
query29 1073 454 455 454
query30 278 162 173 162
query31 1057 840 830 830
query32 100 59 60 59
query33 786 319 329 319
query34 993 530 527 527
query35 928 746 744 744
query36 1136 958 939 939
query37 188 64 69 64
query38 4084 3905 3942 3905
query39 1514 1483 1464 1464
query40 259 103 101 101
query41 50 50 47 47
query42 115 112 110 110
query43 527 492 496 492
query44 1272 833 836 833
query45 187 164 172 164
query46 1203 747 763 747
query47 2026 1935 1916 1916
query48 477 401 394 394
query49 1112 417 407 407
query50 864 446 427 427
query51 7418 7274 7190 7190
query52 101 94 94 94
query53 262 193 193 193
query54 1332 464 481 464
query55 82 80 81 80
query56 277 259 239 239
query57 1325 1195 1173 1173
query58 232 205 218 205
query59 3223 3054 3056 3054
query60 285 257 257 257
query61 118 109 114 109
query62 870 708 702 702
query63 222 202 199 199
query64 5050 675 621 621
query65 3386 3310 3321 3310
query66 1322 296 307 296
query67 16031 15678 15714 15678
query68 4721 596 583 583
query69 430 281 260 260
query70 1151 1079 1087 1079
query71 345 257 291 257
query72 6221 4017 4095 4017
query73 767 345 354 345
query74 10654 8921 9259 8921
query75 3407 2595 2673 2595
query76 2757 1075 1060 1060
query77 404 282 281 281
query78 10556 9556 9470 9470
query79 1677 603 597 597
query80 1044 447 425 425
query81 539 225 223 223
query82 628 92 93 92
query83 238 148 145 145
query84 236 81 84 81
query85 1286 296 313 296
query86 381 301 284 284
query87 4397 4235 4159 4159
query88 3380 2424 2390 2390
query89 414 288 292 288
query90 1904 191 188 188
query91 187 149 154 149
query92 59 54 52 52
query93 1868 558 564 558
query94 816 292 279 279
query95 356 261 254 254
query96 624 280 282 280
query97 3274 3154 3158 3154
query98 209 220 189 189
query99 1508 1330 1290 1290
Total cold run time: 303505 ms
Total hot run time: 192235 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3434805239
@starocean999 Hi, Do you have time to see this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3410563585
<details>
<summary>ClickBench: <b>Total hot run time: 30.13 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e134512d574fa2d3558b6a4d4246af8d833bf7e4, data reload: false
query1 0.04 0.03 0.03
query2 0.07 0.03 0.03
query3 0.24 0.07 0.07
query4 1.63 0.11 0.10
query5 0.51 0.53 0.50
query6 1.13 0.72 0.73
query7 0.02 0.01 0.01
query8 0.04 0.03 0.03
query9 0.59 0.50 0.50
query10 0.55 0.53 0.55
query11 0.14 0.10 0.10
query12 0.14 0.10 0.11
query13 0.60 0.60 0.59
query14 0.77 0.83 0.79
query15 0.84 0.82 0.82
query16 0.38 0.38 0.41
query17 1.00 0.99 0.99
query18 0.24 0.23 0.22
query19 1.89 1.73 1.80
query20 0.01 0.01 0.01
query21 15.40 0.59 0.58
query22 2.18 1.92 2.00
query23 16.84 0.93 1.06
query24 3.60 0.71 1.31
query25 0.26 0.10 0.12
query26 0.39 0.14 0.13
query27 0.04 0.03 0.03
query28 9.89 0.52 0.51
query29 12.57 3.25 3.24
query30 0.26 0.06 0.06
query31 2.86 0.38 0.38
query32 3.25 0.46 0.46
query33 3.00 3.00 3.05
query34 17.06 4.50 4.52
query35 4.53 4.55 4.62
query36 0.68 0.48 0.51
query37 0.09 0.06 0.06
query38 0.04 0.03 0.04
query39 0.04 0.03 0.02
query40 0.16 0.13 0.12
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 104.12 s
Total hot run time: 30.13 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3410477544
<details>
<summary>TPC-H: <b>Total hot run time: 40004 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e134512d574fa2d3558b6a4d4246af8d833bf7e4, data reload: false
------ Round 1 ----------------------------------
q1 17609 6915 6699 6699
q2 2055 214 185 185
q3 10471 1098 1111 1098
q4 10220 780 727 727
q5 7747 2827 2841 2827
q6 208 133 134 133
q7 972 606 594 594
q8 9354 2044 2025 2025
q9 8173 6426 6383 6383
q10 6991 2311 2305 2305
q11 467 268 264 264
q12 398 219 223 219
q13 17831 2953 2969 2953
q14 238 200 201 200
q15 521 456 459 456
q16 481 376 369 369
q17 991 589 549 549
q18 7381 6680 6776 6680
q19 1409 1125 1142 1125
q20 469 202 203 202
q21 3824 3070 3252 3070
q22 1110 1001 941 941
Total cold run time: 108920 ms
Total hot run time: 40004 ms
----- Round 2, with runtime_filter_mode=off -----
q1 6647 6552 6508 6508
q2 333 233 233 233
q3 2969 2926 2929 2926
q4 2057 1863 1752 1752
q5 5775 5738 5682 5682
q6 208 127 131 127
q7 2224 1795 1833 1795
q8 3383 3509 3506 3506
q9 8794 9074 8848 8848
q10 3526 3534 3538 3534
q11 593 494 500 494
q12 839 553 632 553
q13 5867 3144 3143 3143
q14 302 273 282 273
q15 521 451 470 451
q16 486 441 451 441
q17 1889 1683 1612 1612
q18 8329 7760 7784 7760
q19 1650 1501 1451 1451
q20 2123 1886 1906 1886
q21 5125 5056 5005 5005
q22 1155 1044 1037 1037
Total cold run time: 64795 ms
Total hot run time: 59017 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3430370470
# FE UT Coverage Report
Increment line coverage ` 78.08% (57/73)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57022_455942c9d64c76e6ff77de3d9400bdebc45742e8/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57022_455942c9d64c76e6ff77de3d9400bdebc45742e8/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3420411527
<details>
<summary>TPC-DS: <b>Total hot run time: 192701 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 06fbafbb85840e4aa6f12eb752d920aed43c2c51, data reload: false
query1 934 408 400 400
query2 6269 1894 1869 1869
query3 8685 200 196 196
query4 33712 23462 24022 23462
query5 3607 470 439 439
query6 278 182 181 181
query7 4203 311 327 311
query8 291 225 228 225
query9 9736 2563 2548 2548
query10 479 247 262 247
query11 18059 15353 15311 15311
query12 162 105 105 105
query13 1547 429 409 409
query14 8536 7495 6922 6922
query15 234 180 175 175
query16 7984 454 564 454
query17 1602 612 591 591
query18 2170 322 323 322
query19 264 166 166 166
query20 126 117 121 117
query21 209 105 114 105
query22 4938 4581 4342 4342
query23 34950 34653 34099 34099
query24 11325 2987 2959 2959
query25 672 433 432 432
query26 1373 182 177 177
query27 2496 355 361 355
query28 7967 2140 2193 2140
query29 872 474 472 472
query30 273 161 161 161
query31 1017 822 829 822
query32 100 58 59 58
query33 820 300 308 300
query34 974 510 527 510
query35 885 775 726 726
query36 1087 951 947 947
query37 138 74 67 67
query38 4110 3957 3958 3957
query39 1523 1474 1454 1454
query40 209 101 100 100
query41 53 48 47 47
query42 115 101 99 99
query43 502 477 477 477
query44 1248 826 823 823
query45 191 165 179 165
query46 1195 731 738 731
query47 2035 1984 1968 1968
query48 465 373 379 373
query49 1012 421 390 390
query50 845 428 436 428
query51 7513 7166 7314 7166
query52 105 92 91 91
query53 269 193 188 188
query54 1371 469 471 469
query55 83 81 87 81
query56 280 253 262 253
query57 1360 1232 1218 1218
query58 232 209 214 209
query59 3312 2912 3072 2912
query60 307 257 267 257
query61 115 109 109 109
query62 880 735 704 704
query63 225 198 205 198
query64 4074 683 644 644
query65 3396 3282 3332 3282
query66 889 301 306 301
query67 16311 15730 15724 15724
query68 4544 583 587 583
query69 453 272 264 264
query70 1174 1121 1057 1057
query71 335 257 265 257
query72 6317 4062 4200 4062
query73 758 339 360 339
query74 10542 9021 9328 9021
query75 3388 2687 2703 2687
query76 2722 1138 1094 1094
query77 445 273 271 271
query78 10633 9689 9589 9589
query79 2520 613 612 612
query80 1095 417 435 417
query81 553 225 221 221
query82 614 90 93 90
query83 230 146 143 143
query84 239 83 84 83
query85 1549 299 294 294
query86 476 306 284 284
query87 4363 4253 4281 4253
query88 4261 2385 2368 2368
query89 410 294 300 294
query90 1970 187 193 187
query91 192 155 153 153
query92 68 50 51 50
query93 2252 552 540 540
query94 839 299 297 297
query95 365 258 259 258
query96 620 284 279 279
query97 3346 3191 3193 3191
query98 227 207 206 206
query99 1503 1331 1317 1317
Total cold run time: 302202 ms
Total hot run time: 192701 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3420420022
<details>
<summary>ClickBench: <b>Total hot run time: 29.76 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 06fbafbb85840e4aa6f12eb752d920aed43c2c51, data reload: false
query1 0.03 0.03 0.03
query2 0.07 0.04 0.03
query3 0.23 0.06 0.06
query4 1.64 0.10 0.10
query5 0.52 0.50 0.50
query6 1.15 0.75 0.73
query7 0.02 0.01 0.01
query8 0.04 0.03 0.03
query9 0.58 0.50 0.51
query10 0.55 0.55 0.56
query11 0.15 0.10 0.10
query12 0.13 0.11 0.11
query13 0.61 0.60 0.60
query14 0.79 0.80 0.81
query15 0.84 0.81 0.82
query16 0.37 0.41 0.41
query17 0.99 1.00 0.97
query18 0.23 0.24 0.22
query19 1.85 1.90 1.84
query20 0.02 0.01 0.01
query21 15.40 0.60 0.59
query22 2.78 1.83 1.57
query23 17.08 0.89 0.83
query24 3.57 0.65 0.49
query25 0.17 0.15 0.10
query26 0.44 0.14 0.13
query27 0.05 0.04 0.05
query28 10.97 0.50 0.48
query29 12.59 3.31 3.29
query30 0.25 0.07 0.06
query31 2.86 0.37 0.38
query32 3.25 0.47 0.46
query33 3.03 3.04 3.04
query34 17.07 4.46 4.60
query35 4.58 4.66 4.66
query36 0.66 0.48 0.48
query37 0.10 0.06 0.06
query38 0.05 0.03 0.04
query39 0.03 0.02 0.02
query40 0.16 0.12 0.12
query41 0.08 0.03 0.02
query42 0.04 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 106.06 s
Total hot run time: 29.76 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3410401410
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3409920274
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3409020350
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3420321966
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3431187137
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3421179388
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3425051520
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3425235283
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 merged PR #57022:
URL: https://github.com/apache/doris/pull/57022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3409878401
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.0: [fix](nereids)scalar subquery should not show error message when there are multiple agg functions in top-level agg node #52667 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57022:
URL: https://github.com/apache/doris/pull/57022#issuecomment-3410195496
# FE UT Coverage Report
Increment line coverage ` 78.08% (57/73)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57022_95591368cdc23cb35eb3bfed7f1933049aa5167e/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57022_95591368cdc23cb35eb3bfed7f1933049aa5167e/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org