You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <ch...@yahoo-inc.com> on 2012/02/24 01:28:43 UTC
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/
-----------------------------------------------------------
(Updated 2012-02-24 00:28:43.339663)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Summary
-------
This patch was originally worked on by Mayank Bansal.
I (Mona Chitnis) am in charge of handling this review request.
Description - adding hadoop.next support for oozie
This addresses bug OOZIE-477.
https://issues.apache.org/jira/browse/OOZIE-477
Diffs
-----
trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1175987
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1175987
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1175987
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1175987
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1175987
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java 1175987
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1175987
trunk/core/src/main/resources/oozie-default.xml 1175987
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1175987
Diff: https://reviews.apache.org/r/2059/diff
Testing
-------
tested against current unit tests
Thanks,
Mona
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6087
-----------------------------------------------------------
Overall pls check the oozie formatting. Looks like there are some changes that are not related to this.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/2059/#comment13062>
We can break the loop here.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/2059/#comment13063>
remove this line.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/2059/#comment13065>
This could be a boolean value that will remove the "SUPPORT_MULTICLUSTER_ON" variable
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/2059/#comment13064>
Why are we hard-coding the "JavaActionExecutor"?
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
<https://reviews.apache.org/r/2059/#comment13066>
why this many line? please use the oozie-formatting.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
<https://reviews.apache.org/r/2059/#comment13067>
I think int he new code "group.name" is removed from all over.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
<https://reviews.apache.org/r/2059/#comment13068>
same for 'group'
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
<https://reviews.apache.org/r/2059/#comment13069>
extra space
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
<https://reviews.apache.org/r/2059/#comment13070>
formatting all over
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java
<https://reviews.apache.org/r/2059/#comment13071>
why these new two imports?
- Mohammad
On 2012-03-09 02:36:56, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-09 02:36:56)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/core/src/main/resources/oozie-default.xml 1298499
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1298499
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1298499
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java 1298499
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1298499
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1298499
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1298499
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1298499
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1298499
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
> On 2012-03-24 04:26:38, mayank wrote:
> > +1
Can we please hold on committing this, I'd like my comments be answered.
Thxs.
Alejandro
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6321
-----------------------------------------------------------
On 2012-03-22 17:27:37, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-22 17:27:37)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1303609
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by ma...@apache.org.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6321
-----------------------------------------------------------
Ship it!
+1
- mayank
On 2012-03-22 17:27:37, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-22 17:27:37)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1303609
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6332
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/2059/#comment13756>
This requirement came up when Mayank tested for multiple NN (federation) support. Without that , multiple NN access was not working. I remember Sanjay Radia proposed to follow this approach to get the URI.
However it was a very long time back.
- Mohammad
On 2012-03-22 17:27:37, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-22 17:27:37)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1303609
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
> On 2012-03-27 20:14:21, Alejandro Abdelnur wrote:
> > The check for supported FS schemes should also be done in the submission of the WF/COORD/BUNDLE job, no?
Yes thats right. As I replied to your earlier comment, there can be other places too, in addition to JavaActionExecutor where code change is required for federation. I am going to address that requirement in another JIRA OOZIE-782. This JIRA will be only to remove the hardcoding of "hdfs://"
> On 2012-03-27 20:14:21, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, line 1091
> > <https://reviews.apache.org/r/2059/diff/7/?file=96447#file96447line1091>
> >
> > this seems like a complete different thing from enabling different filesystem schemes. we should do this as part of a different JIRA
Moving this out of this JIRA and into OOZIE-782
> On 2012-03-27 20:14:21, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java, line 248
> > <https://reviews.apache.org/r/2059/diff/7/?file=96449#file96449line248>
> >
> > (String) casting is not required
done
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6442
-----------------------------------------------------------
On 2012-03-27 00:15:40, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-27 00:15:40)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6442
-----------------------------------------------------------
The check for supported FS schemes should also be done in the submission of the WF/COORD/BUNDLE job, no?
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/2059/#comment14064>
this seems like a complete different thing from enabling different filesystem schemes. we should do this as part of a different JIRA
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
<https://reviews.apache.org/r/2059/#comment14063>
(String) casting is not required
- Alejandro
On 2012-03-27 00:15:40, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-27 00:15:40)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
> On 2012-03-28 19:47:57, Alejandro Abdelnur wrote:
> > I think my previous comment on the WFApp not checking the supported filesystems was not fully understood.
> >
> > We should check that the app path is for a supported filesystem and fail if not. else people could write WFs in the local filesystem or NFS and loaded from Oozie. This should be possible only if it is a supported filesystem
added the Wf app path check. To avoid code repetition, defined this logic of "checkSupportedFilesystem" in parent class ActionExecutor and invoking from JavaAE and FsAE. Modified/added respective testcases.
> On 2012-03-28 19:47:57, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java, line 358
> > <https://reviews.apache.org/r/2059/diff/8/?file=97129#file97129line358>
> >
> > this should be done once, if supportedSchemes is null. it should be done within a synchronized block:
> >
> > synch {
> > if (supportedSchemes == null) {
> > ///load
> > }
> > }
> >
> > this would create minimum contention as there is no logic at all after the first pass that loads the supported schemes
done
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6487
-----------------------------------------------------------
On 2012-03-28 00:14:46, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-28 00:14:46)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6487
-----------------------------------------------------------
I think my previous comment on the WFApp not checking the supported filesystems was not fully understood.
We should check that the app path is for a supported filesystem and fail if not. else people could write WFs in the local filesystem or NFS and loaded from Oozie. This should be possible only if it is a supported filesystem
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/2059/#comment14136>
this should be done once, if supportedSchemes is null. it should be done within a synchronized block:
synch {
if (supportedSchemes == null) {
///load
}
}
this would create minimum contention as there is no logic at all after the first pass that loads the supported schemes
- Alejandro
On 2012-03-28 00:14:46, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-28 00:14:46)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
> On 2012-03-29 10:42:44, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java, line 153
> > <https://reviews.apache.org/r/2059/diff/9/?file=97338#file97338line153>
> >
> > what am i missing? i still don't see the scheme being check here.
>
> Mona Chitnis wrote:
> Wouldn't the checking in respective action executors suffice ?
we should use the same scheme check to enforce where Oozie apps (XMLs) can be read from. Not only for WFs but for COORDs and BUNDLEs
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6513
-----------------------------------------------------------
On 2012-03-29 10:29:06, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-29 10:29:06)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
> On 2012-03-29 10:42:44, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java, line 334
> > <https://reviews.apache.org/r/2059/diff/9/?file=97335#file97335line334>
> >
> > the synchronization cannot be on the current action instance as actions are created every time they are needed. the synchronization should be on something global, ie the class hosting this method
ok. fixing
> On 2012-03-29 10:42:44, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java, line 341
> > <https://reviews.apache.org/r/2059/diff/9/?file=97335#file97335line341>
> >
> > again, this is suppose to be part of another JIRA, no?
similar to above comment for this variable.
> On 2012-03-29 10:42:44, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java, line 46
> > <https://reviews.apache.org/r/2059/diff/9/?file=97335#file97335line46>
> >
> > wasn't this going to be addressed by another JIRA?
this safeguard was required against the case if there are blank entries for "oozie.filesystems.supported" in oozie-site.xml or other places to configure. In that case, variable 'supportedSchemes' in ActionExecutor will be "" and all schemes will fail at check.
> On 2012-03-29 10:42:44, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, line 202
> > <https://reviews.apache.org/r/2059/diff/9/?file=97336#file97336line202>
> >
> > this code is duplicated in FSActionExecutor, it seems it should be factored out and reused.
> >
> > Furthermore, should this be loaded then by the ActionExecutor class itself?
Checking if can be factored out up into ActionExecutor
> On 2012-03-29 10:42:44, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java, line 153
> > <https://reviews.apache.org/r/2059/diff/9/?file=97338#file97338line153>
> >
> > what am i missing? i still don't see the scheme being check here.
Wouldn't the checking in respective action executors suffice ?
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6513
-----------------------------------------------------------
On 2012-03-29 10:29:06, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-29 10:29:06)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6513
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/2059/#comment14168>
wasn't this going to be addressed by another JIRA?
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/2059/#comment14169>
the synchronization cannot be on the current action instance as actions are created every time they are needed. the synchronization should be on something global, ie the class hosting this method
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/2059/#comment14170>
again, this is suppose to be part of another JIRA, no?
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/2059/#comment14171>
this code is duplicated in FSActionExecutor, it seems it should be factored out and reused.
Furthermore, should this be loaded then by the ActionExecutor class itself?
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
<https://reviews.apache.org/r/2059/#comment14172>
what am i missing? i still don't see the scheme being check here.
- Alejandro
On 2012-03-29 10:29:06, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-29 10:29:06)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review8362
-----------------------------------------------------------
closing this review request as there is some activity in the corresponding JIRA and we don't use review request anymore.
- Alejandro Abdelnur
On March 29, 2012, 10:29 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated March 29, 2012, 10:29 a.m.)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Description
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1303609
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1303609
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff/
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/
-----------------------------------------------------------
(Updated 2012-03-29 10:29:06.751615)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
review feedback addressed.
Summary
-------
This patch was originally worked on by Mayank Bansal.
I (Mona Chitnis) am in charge of handling this review request.
Description - adding hadoop.next support for oozie
This addresses bug OOZIE-477.
https://issues.apache.org/jira/browse/OOZIE-477
Diffs (updated)
-----
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1303609
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
trunk/core/src/main/resources/oozie-default.xml 1303609
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
Diff: https://reviews.apache.org/r/2059/diff
Testing
-------
tested against current unit tests
Thanks,
Mona
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/
-----------------------------------------------------------
(Updated 2012-03-28 00:14:46.724524)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
incorporated review feedback. Scope of JIRA made to only avoid "hdfs://" hardcoding. Checking supported schema for workflow/coord/bundle job submission in various action executors will be addressed in OOZIE-782
Summary
-------
This patch was originally worked on by Mayank Bansal.
I (Mona Chitnis) am in charge of handling this review request.
Description - adding hadoop.next support for oozie
This addresses bug OOZIE-477.
https://issues.apache.org/jira/browse/OOZIE-477
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
trunk/core/src/main/resources/oozie-default.xml 1303609
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
Diff: https://reviews.apache.org/r/2059/diff
Testing
-------
tested against current unit tests
Thanks,
Mona
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/
-----------------------------------------------------------
(Updated 2012-03-27 00:15:40.905318)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
addressed review feedback.
Summary
-------
This patch was originally worked on by Mayank Bansal.
I (Mona Chitnis) am in charge of handling this review request.
Description - adding hadoop.next support for oozie
This addresses bug OOZIE-477.
https://issues.apache.org/jira/browse/OOZIE-477
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
trunk/core/src/main/resources/oozie-default.xml 1303609
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
Diff: https://reviews.apache.org/r/2059/diff
Testing
-------
tested against current unit tests
Thanks,
Mona
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by ma...@apache.org.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6323
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/2059/#comment13738>
Remove this method
- mayank
On 2012-03-22 17:27:37, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-22 17:27:37)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1303609
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
> On 2012-03-23 20:46:30, Alejandro Abdelnur wrote:
> > the FSActionExecutor is checking for the allowed filesystem schemes. It seems the JavaActionExecutor and the submit job command should do the same, no?
In earlier code, the FsActionExecutor had hardcoding of "hdfs://" scheme. This patch is mainly directed to remove that hardcoding and allow flexibility in schemes, through configuration. There can be other places too, in addition to JavaActionExecutor where code change is required for federation. I am opening another JIRA to address that requirement.
> On 2012-03-23 20:46:30, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java, line 97
> > <https://reviews.apache.org/r/2059/diff/6/?file=94571#file94571line97>
> >
> > this is a non-relevant change. please revert
ok
> On 2012-03-23 20:46:30, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java, line 102
> > <https://reviews.apache.org/r/2059/diff/6/?file=94571#file94571line102>
> >
> > same same
ok
> On 2012-03-23 20:46:30, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java, line 98
> > <https://reviews.apache.org/r/2059/diff/6/?file=94568#file94568line98>
> >
> > we should read/parse/trim the supported filesystem schemes once (at init time, or first time) and then cache the array
agreed. otherwise the config property - supported schemes, is being retrieved repeatedly. fixed.
> On 2012-03-23 20:46:30, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, line 1114
> > <https://reviews.apache.org/r/2059/diff/6/?file=94569#file94569line1114>
> >
> > where is this method used?
removing method since it is not used.
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6307
-----------------------------------------------------------
On 2012-03-22 17:27:37, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-22 17:27:37)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1303609
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6307
-----------------------------------------------------------
the FSActionExecutor is checking for the allowed filesystem schemes. It seems the JavaActionExecutor and the submit job command should do the same, no?
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/2059/#comment13691>
we should read/parse/trim the supported filesystem schemes once (at init time, or first time) and then cache the array
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/2059/#comment13695>
what is this multicluster safeguard check? don't understand what does it prevent/enable
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/2059/#comment13694>
where is this method used?
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
<https://reviews.apache.org/r/2059/#comment13687>
this is a non-relevant change. please revert
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
<https://reviews.apache.org/r/2059/#comment13688>
same same
- Alejandro
On 2012-03-22 17:27:37, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2059/
> -----------------------------------------------------------
>
> (Updated 2012-03-22 17:27:37)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This patch was originally worked on by Mayank Bansal.
> I (Mona Chitnis) am in charge of handling this review request.
>
> Description - adding hadoop.next support for oozie
>
>
> This addresses bug OOZIE-477.
> https://issues.apache.org/jira/browse/OOZIE-477
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1303609
> trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
> trunk/core/src/main/resources/oozie-default.xml 1303609
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
>
> Diff: https://reviews.apache.org/r/2059/diff
>
>
> Testing
> -------
>
> tested against current unit tests
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/
-----------------------------------------------------------
(Updated 2012-03-22 17:27:37.492001)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
reverted change to oozie.supported.multicluster property=false in oozie-default.xml
Summary
-------
This patch was originally worked on by Mayank Bansal.
I (Mona Chitnis) am in charge of handling this review request.
Description - adding hadoop.next support for oozie
This addresses bug OOZIE-477.
https://issues.apache.org/jira/browse/OOZIE-477
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1303609
trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
trunk/core/src/main/resources/oozie-default.xml 1303609
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
Diff: https://reviews.apache.org/r/2059/diff
Testing
-------
tested against current unit tests
Thanks,
Mona
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/
-----------------------------------------------------------
(Updated 2012-03-22 08:00:43.598561)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
incorporated review feedback
Summary
-------
This patch was originally worked on by Mayank Bansal.
I (Mona Chitnis) am in charge of handling this review request.
Description - adding hadoop.next support for oozie
This addresses bug OOZIE-477.
https://issues.apache.org/jira/browse/OOZIE-477
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1303609
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1303609
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1303609
trunk/core/src/main/resources/oozie-default.xml 1303609
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1303609
Diff: https://reviews.apache.org/r/2059/diff
Testing
-------
tested against current unit tests
Thanks,
Mona
Re: Review Request: OOZIE-477 Adding configurable filesystem support instead
of hardcoded "hdfs"
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/
-----------------------------------------------------------
(Updated 2012-03-09 02:36:56.083797)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
rebased after trunk update to apply cleanly
Summary
-------
This patch was originally worked on by Mayank Bansal.
I (Mona Chitnis) am in charge of handling this review request.
Description - adding hadoop.next support for oozie
This addresses bug OOZIE-477.
https://issues.apache.org/jira/browse/OOZIE-477
Diffs (updated)
-----
trunk/core/src/main/resources/oozie-default.xml 1298499
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1298499
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1298499
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java 1298499
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1298499
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1298499
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1298499
trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1298499
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1298499
Diff: https://reviews.apache.org/r/2059/diff
Testing
-------
tested against current unit tests
Thanks,
Mona