You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/06 15:14:56 UTC
[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request
#4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
xiyelife opened a new pull request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
URL: https://github.com/apache/incubator-shardingsphere/pull/4193
Fixes #4037.
Changes proposed in this pull request:
- parse the IN operator bracket's index for encrypt rewirte
- fixes encrypt statement IN operator contains space and `\n` `\t` `\r`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4193:
Fixes #4037. IN operator contains space and `\n` `\t` `\r`
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
URL: https://github.com/apache/incubator-shardingsphere/pull/4193#issuecomment-586083356
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`4.0.1@c82eb0a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `8.33%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 4.0.1 #4193 +/- ##
========================================
Coverage ? 63.33%
Complexity ? 876
========================================
Files ? 1057
Lines ? 17001
Branches ? 2739
========================================
Hits ? 10767
Misses ? 5631
Partials ? 603
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ardingsphere/sql/parser/core/constant/Bracket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2NvbnN0YW50L0JyYWNrZXQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...dml/predicate/value/PredicateLeftBracketValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvcHJlZGljYXRlL3ZhbHVlL1ByZWRpY2F0ZUxlZnRCcmFja2V0VmFsdWUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ent/dml/predicate/value/PredicateInRightValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvcHJlZGljYXRlL3ZhbHVlL1ByZWRpY2F0ZUluUmlnaHRWYWx1ZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ent/dml/predicate/value/PredicateBracketValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvcHJlZGljYXRlL3ZhbHVlL1ByZWRpY2F0ZUJyYWNrZXRWYWx1ZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ml/predicate/value/PredicateRightBracketValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvcHJlZGljYXRlL3ZhbHVlL1ByZWRpY2F0ZVJpZ2h0QnJhY2tldFZhbHVlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...er/core/extractor/impl/dml/PredicateExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2RtbC9QcmVkaWNhdGVFeHRyYWN0b3IuamF2YQ==) | `2.25% <0%> (ø)` | `0 <0> (?)` | |
| [...impl/EncryptPredicateRightValueTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvRW5jcnlwdFByZWRpY2F0ZVJpZ2h0VmFsdWVUb2tlbkdlbmVyYXRvci5qYXZh) | `92.85% <100%> (ø)` | `2 <0> (?)` | |
| [...sphere/encrypt/rewrite/EncryptConditionEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvRW5jcnlwdENvbmRpdGlvbkVuZ2luZS5qYXZh) | `61.22% <66.66%> (ø)` | `1 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193?src=pr&el=footer). Last update [c82eb0a...d380b78](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4193?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao closed pull request #4193:
Fixes #4037. IN operator contains space and `\n` `\t` `\r`
Posted by GitBox <gi...@apache.org>.
cherrylzhao closed pull request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
URL: https://github.com/apache/incubator-shardingsphere/pull/4193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4193:
Fixes #4037. IN operator contains space and `\n` `\t` `\r`
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
URL: https://github.com/apache/incubator-shardingsphere/pull/4193#issuecomment-584548661
Can you submit a pull request to master as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request
#4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
Posted by GitBox <gi...@apache.org>.
xiyelife opened a new pull request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
URL: https://github.com/apache/incubator-shardingsphere/pull/4193
Fixes #4037.
Changes proposed in this pull request:
- parse the IN operator bracket's index for encrypt rewirte
- fixes encrypt statement IN operator contains space and `\n` `\t` `\r`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
URL: https://github.com/apache/incubator-shardingsphere/pull/4193#discussion_r375971137
##########
File path: encrypt-core/encrypt-core-rewrite/src/test/resources/encrypt/select_for_query_with_cipher.xml
##########
@@ -36,4 +36,26 @@
<input sql="SELECT a.account_id, a.password, a.amount AS a, a.status AS s FROM t_account_bak AS a WHERE a.account_id = 1 AND a.password = 'aaa' AND a.amount = 1000 AND a.status = 'OK'" />
<output sql="SELECT a.account_id, a.cipher_password, a.cipher_amount AS a, a.status AS s FROM t_account_bak AS a WHERE a.account_id = 1 AND a.assisted_query_password = 'assisted_query_aaa' AND a.cipher_amount = 'encrypt_1000' AND a.status = 'OK'" />
</rewrite-assertion>
+
+ <rewrite-assertion id="select_plain_for_parameters_with_in_no_space1">
Review comment:
please use meaningful name, avoid name as `xxxx1` or `xxxx2`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on issue #4193: Fixes
#4037. IN operator contains space and `\n` `\t` `\r`
Posted by GitBox <gi...@apache.org>.
xiyelife commented on issue #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
URL: https://github.com/apache/incubator-shardingsphere/pull/4193#issuecomment-585826876
> Can you submit a pull request to master as well?
I have fixed it by this PR https://github.com/apache/incubator-shardingsphere/pull/4193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on a change in pull
request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
Posted by GitBox <gi...@apache.org>.
xiyelife commented on a change in pull request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
URL: https://github.com/apache/incubator-shardingsphere/pull/4193#discussion_r376192010
##########
File path: encrypt-core/encrypt-core-rewrite/src/test/resources/encrypt/select_for_query_with_cipher.xml
##########
@@ -36,4 +36,26 @@
<input sql="SELECT a.account_id, a.password, a.amount AS a, a.status AS s FROM t_account_bak AS a WHERE a.account_id = 1 AND a.password = 'aaa' AND a.amount = 1000 AND a.status = 'OK'" />
<output sql="SELECT a.account_id, a.cipher_password, a.cipher_amount AS a, a.status AS s FROM t_account_bak AS a WHERE a.account_id = 1 AND a.assisted_query_password = 'assisted_query_aaa' AND a.cipher_amount = 'encrypt_1000' AND a.status = 'OK'" />
</rewrite-assertion>
+
+ <rewrite-assertion id="select_plain_for_parameters_with_in_no_space1">
Review comment:
I see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao merged pull request #4193:
Fixes #4037. IN operator contains space and `\n` `\t` `\r`
Posted by GitBox <gi...@apache.org>.
cherrylzhao merged pull request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`
URL: https://github.com/apache/incubator-shardingsphere/pull/4193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services