You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Henry Saputra (JIRA)" <ji...@apache.org> on 2010/05/21 17:14:17 UTC
[jira] Updated: (SHINDIG-1339) Change the modifier of the static
member variables for BasicImageRewriter from public to private since they
dont need to be public.
[ https://issues.apache.org/jira/browse/SHINDIG-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra updated SHINDIG-1339:
-----------------------------------
Summary: Change the modifier of the static member variables for BasicImageRewriter from public to private since they dont need to be public. (was: Change the scope of the static member variables for BasicImageRewriter from public to private since they dont need to be public.)
Description:
Change the public modifier for static variables in BasicImageRewriter that exposes UriCommon.Param enums as private since they serve no purpose other than used in the unit test.
Change CONTENT_TYPE_AND_EXTENSION_MISMATCH and CONTENT_TYPE_AND_MIME_MISMATCH as package private for easy access from the unit test.
Updated the unit test to reflect this.
Code review at
http://codereview.appspot.com/1211045/show
was:
Change the public scope for static variables in BasicImageRewriter that exposes UriCommon.Param enums as private since they serve no purpose other than used in the unit test.
Change CONTENT_TYPE_AND_EXTENSION_MISMATCH and CONTENT_TYPE_AND_MIME_MISMATCH as package private for easy access from the unit test.
Updated the unit test to reflect this.
Code review at
http://codereview.appspot.com/1211045/show
> Change the modifier of the static member variables for BasicImageRewriter from public to private since they dont need to be public.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1339
> URL: https://issues.apache.org/jira/browse/SHINDIG-1339
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.0
> Reporter: Henry Saputra
> Priority: Minor
> Attachments: pub_to_priv.patch
>
>
> Change the public modifier for static variables in BasicImageRewriter that exposes UriCommon.Param enums as private since they serve no purpose other than used in the unit test.
> Change CONTENT_TYPE_AND_EXTENSION_MISMATCH and CONTENT_TYPE_AND_MIME_MISMATCH as package private for easy access from the unit test.
> Updated the unit test to reflect this.
> Code review at
> http://codereview.appspot.com/1211045/show
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.