You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/04 16:42:17 UTC

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #10891: [Hexagon] Select qaic executable based on Ubuntu version

kparzysz-quic commented on code in PR #10891:
URL: https://github.com/apache/tvm/pull/10891#discussion_r841943532


##########
cmake/modules/HexagonSDK.cmake:
##########
@@ -97,11 +132,26 @@ function(_get_hexagon_sdk_property_impl
     endif()
 
   elseif(_property STREQUAL "QAIC_EXE")
-    _check_path_exists(
-      "${_hexagon_sdk_root}/ipc/fastrpc/qaic/Ubuntu18/qaic"
-      _qaic_path
-    )
-    set_parent(${_output_variable} "${_qaic_path}")
+    set(_override $ENV{QAIC_PATH_OVERRIDE})

Review Comment:
   The motivation for an environment variable is that one can set it and then use cmake as if nothing happened, so to speak.  Since cmake calls itself recursively when building various projects, passing of a cmake variable would need to be explicit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org