You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/09/09 17:28:46 UTC
[jira] [Commented] (CB-9631) 'plugin add --save' saves plugin entry
even if plugin installation fails
[ https://issues.apache.org/jira/browse/CB-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737034#comment-14737034 ]
ASF GitHub Bot commented on CB-9631:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/303
CB-9631 Save plugin to config.xml only if installation succeeds
This fixes [CB-9631](https://issues.apache.org/jira/browse/CB-9631)
The idea is that we need to save installed plugins to config.xml only if installation succeeds (similar to platform save)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9631
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #303
----
commit aaf0a12857b6bf1b78ace8f71985ce745124f563
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-09-09T14:58:21Z
CB-9631 Save plugin to config.xml only if installation succeeds
----
> 'plugin add --save' saves plugin entry even if plugin installation fails
> ------------------------------------------------------------------------
>
> Key: CB-9631
> URL: https://issues.apache.org/jira/browse/CB-9631
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: Master
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> *Repro steps:*
> 1. cordova create new-app && cd new-app
> 2. cordova platform add browser
> 3. cordova plugin add https://github.com/Wizcorp/phonegap-facebook-plugin.git --save
> Installation fails since no plugin variables specified
> *Expected:*
> Because the plugin installation failed, plugin entry is not persisted in config.xml
> *Actual:*
> config.xml contains plugin entry (empty, without variables).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org