[GitHub] [incubator-heron] dnrusakov edited a comment on issue #3207: broken zookeeper dependancy fixed

[GitBox <gi...@apache.org>]

dnrusakov edited a comment on issue #3207: broken zookeeper dependancy fixed
URL: https://github.com/apache/incubator-heron/pull/3207#issuecomment-469903286
 
 
   @dave2wave 
   
   Yes, ZK is available in Maven Central. However, it doesn't have C++ sources on board...
   
   So, when I tried to replace
   
   ```
   new_http_archive(
       name = "org_apache_zookeeper",
       urls = [
         "http://archive.apache.org/dist/zookeeper/zookeeper-3.4.10/zookeeper-3.4.10.tar.gz",
       ],
       strip_prefix = "zookeeper-3.4.10",
       build_file = "third_party/zookeeper/zookeeper.BUILD",
       sha256 = "7f7f5414e044ac11fee2a1e0bc225469f51fb0cdf821e67df762a43098223f27",
   )
   ```
   
   with
   
   ```
   maven_jar(
     name = "org_apache_zookeeper",
     artifact = "org.apache.zookeeper:zookeeper:3.4.10",
   )
   ```
   
   it failed to compile:
   
   ```
   ERROR: /Users/drusakov/workspace/incubator-heron/heron/common/src/cpp/zookeeper/BUILD:3:1: no such package '@org_apache_zookeeper//': BUILD file not found on package path and referenced by '//heron/common/src/cpp/zookeeper:zookeeper-cxx'.
   ERROR: Analysis of target '//heron/tmaster/src/cpp:tmaster-cxx' failed; build aborted.
   ```
   
   Any ideas?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services