You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Kay Kay (JIRA)" <ji...@apache.org> on 2010/01/15 09:49:54 UTC
[jira] Created: (THRIFT-679) Reorganize directories under lib/java
as per mvn format to make things easy
Reorganize directories under lib/java as per mvn format to make things easy
---------------------------------------------------------------------------
Key: THRIFT-679
URL: https://issues.apache.org/jira/browse/THRIFT-679
Project: Thrift
Issue Type: Sub-task
Components: Library (Java)
Reporter: Kay Kay
Attachments: THRIFT-679.patch
Under lib/java - we have src and test -
To begin with - we need to change the src tree a little bit to make things easy for maven repository publishing.
- Code under src/** should be moved to src/main/java
Code under test/** should be moved to src/test/java
Create appropriate directories in svn and move the source tree using svn commands.
Apply the patch attached to build.xml to make sure that the current build continues to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-679) Reorganize directories under
lib/java as per mvn format to make things easy
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800780#action_12800780 ]
Kay Kay commented on THRIFT-679:
--------------------------------
After the sources are removed - the build.xml would address that . ( to be applied from lib/java ) .
> Reorganize directories under lib/java as per mvn format to make things easy
> ---------------------------------------------------------------------------
>
> Key: THRIFT-679
> URL: https://issues.apache.org/jira/browse/THRIFT-679
> Project: Thrift
> Issue Type: Sub-task
> Components: Library (Java)
> Reporter: Kay Kay
> Attachments: THRIFT-679.patch
>
>
> Under lib/java - we have src and test -
> To begin with - we need to change the src tree a little bit to make things easy for maven repository publishing.
> - Code under src/** should be moved to src/main/java
> Code under test/** should be moved to src/test/java
> Create appropriate directories in svn and move the source tree using svn commands.
> Apply the patch attached to build.xml to make sure that the current build continues to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-679) Reorganize directories under
lib/java as per mvn format to make things easy
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800783#action_12800783 ]
Kay Kay commented on THRIFT-679:
--------------------------------
{quote}
I guess I don't understand why it's important where the test files are. Are you planning to make them part of the package? I would not be in favor of that.
{quote}
No - the test files are not going to be in the package.
It is just a different tree structure. Just like src and test exist today in current directory - this reorganization will make them available in a different structure, totally separated from each other.
> Reorganize directories under lib/java as per mvn format to make things easy
> ---------------------------------------------------------------------------
>
> Key: THRIFT-679
> URL: https://issues.apache.org/jira/browse/THRIFT-679
> Project: Thrift
> Issue Type: Sub-task
> Components: Library (Java)
> Reporter: Kay Kay
> Attachments: THRIFT-679.patch
>
>
> Under lib/java - we have src and test -
> To begin with - we need to change the src tree a little bit to make things easy for maven repository publishing.
> - Code under src/** should be moved to src/main/java
> Code under test/** should be moved to src/test/java
> Create appropriate directories in svn and move the source tree using svn commands.
> Apply the patch attached to build.xml to make sure that the current build continues to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-679) Reorganize directories under lib/java
as per mvn format to make things easy
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay resolved THRIFT-679.
----------------------------
Resolution: Won't Fix
> Reorganize directories under lib/java as per mvn format to make things easy
> ---------------------------------------------------------------------------
>
> Key: THRIFT-679
> URL: https://issues.apache.org/jira/browse/THRIFT-679
> Project: Thrift
> Issue Type: Sub-task
> Components: Library (Java)
> Reporter: Kay Kay
> Attachments: THRIFT-679.patch
>
>
> Under lib/java - we have src and test -
> To begin with - we need to change the src tree a little bit to make things easy for maven repository publishing.
> - Code under src/** should be moved to src/main/java
> Code under test/** should be moved to src/test/java
> Create appropriate directories in svn and move the source tree using svn commands.
> Apply the patch attached to build.xml to make sure that the current build continues to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-679) Reorganize directories under
lib/java as per mvn format to make things easy
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800767#action_12800767 ]
Bryan Duxbury commented on THRIFT-679:
--------------------------------------
Why does the test source and the lib source have to be under the same directory?
> Reorganize directories under lib/java as per mvn format to make things easy
> ---------------------------------------------------------------------------
>
> Key: THRIFT-679
> URL: https://issues.apache.org/jira/browse/THRIFT-679
> Project: Thrift
> Issue Type: Sub-task
> Components: Library (Java)
> Reporter: Kay Kay
> Attachments: THRIFT-679.patch
>
>
> Under lib/java - we have src and test -
> To begin with - we need to change the src tree a little bit to make things easy for maven repository publishing.
> - Code under src/** should be moved to src/main/java
> Code under test/** should be moved to src/test/java
> Create appropriate directories in svn and move the source tree using svn commands.
> Apply the patch attached to build.xml to make sure that the current build continues to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-679) Reorganize directories under lib/java
as per mvn format to make things easy
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated THRIFT-679:
---------------------------
Attachment: THRIFT-679.patch
> Reorganize directories under lib/java as per mvn format to make things easy
> ---------------------------------------------------------------------------
>
> Key: THRIFT-679
> URL: https://issues.apache.org/jira/browse/THRIFT-679
> Project: Thrift
> Issue Type: Sub-task
> Components: Library (Java)
> Reporter: Kay Kay
> Attachments: THRIFT-679.patch
>
>
> Under lib/java - we have src and test -
> To begin with - we need to change the src tree a little bit to make things easy for maven repository publishing.
> - Code under src/** should be moved to src/main/java
> Code under test/** should be moved to src/test/java
> Create appropriate directories in svn and move the source tree using svn commands.
> Apply the patch attached to build.xml to make sure that the current build continues to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-679) Reorganize directories under
lib/java as per mvn format to make things easy
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800773#action_12800773 ]
Kay Kay commented on THRIFT-679:
--------------------------------
{quote}
Why does the test source and the lib source have to be under the same directory?
{quote}
No - they are not . They are under different directories - src/main/java and src/test/java . That is setting them up for maven project format for easy publishing of artifacts. ( http://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html ). The work-around is painful though.
> Reorganize directories under lib/java as per mvn format to make things easy
> ---------------------------------------------------------------------------
>
> Key: THRIFT-679
> URL: https://issues.apache.org/jira/browse/THRIFT-679
> Project: Thrift
> Issue Type: Sub-task
> Components: Library (Java)
> Reporter: Kay Kay
> Attachments: THRIFT-679.patch
>
>
> Under lib/java - we have src and test -
> To begin with - we need to change the src tree a little bit to make things easy for maven repository publishing.
> - Code under src/** should be moved to src/main/java
> Code under test/** should be moved to src/test/java
> Create appropriate directories in svn and move the source tree using svn commands.
> Apply the patch attached to build.xml to make sure that the current build continues to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-679) Reorganize directories under
lib/java as per mvn format to make things easy
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801096#action_12801096 ]
Kay Kay commented on THRIFT-679:
--------------------------------
Sorry - this is not needed. I was initially planning to use mvn as build system - but I guess we can just get away with maven ant tasks.
> Reorganize directories under lib/java as per mvn format to make things easy
> ---------------------------------------------------------------------------
>
> Key: THRIFT-679
> URL: https://issues.apache.org/jira/browse/THRIFT-679
> Project: Thrift
> Issue Type: Sub-task
> Components: Library (Java)
> Reporter: Kay Kay
> Attachments: THRIFT-679.patch
>
>
> Under lib/java - we have src and test -
> To begin with - we need to change the src tree a little bit to make things easy for maven repository publishing.
> - Code under src/** should be moved to src/main/java
> Code under test/** should be moved to src/test/java
> Create appropriate directories in svn and move the source tree using svn commands.
> Apply the patch attached to build.xml to make sure that the current build continues to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-679) Reorganize directories under
lib/java as per mvn format to make things easy
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800779#action_12800779 ]
Bryan Duxbury commented on THRIFT-679:
--------------------------------------
I guess I don't understand why it's important where the test files are. Are you planning to make them part of the package? I would not be in favor of that.
> Reorganize directories under lib/java as per mvn format to make things easy
> ---------------------------------------------------------------------------
>
> Key: THRIFT-679
> URL: https://issues.apache.org/jira/browse/THRIFT-679
> Project: Thrift
> Issue Type: Sub-task
> Components: Library (Java)
> Reporter: Kay Kay
> Attachments: THRIFT-679.patch
>
>
> Under lib/java - we have src and test -
> To begin with - we need to change the src tree a little bit to make things easy for maven repository publishing.
> - Code under src/** should be moved to src/main/java
> Code under test/** should be moved to src/test/java
> Create appropriate directories in svn and move the source tree using svn commands.
> Apply the patch attached to build.xml to make sure that the current build continues to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.