You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/02/05 01:42:12 UTC

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag 

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12362


Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................

IMPALA-8105: [DOCS] Document cache_remote_file_handles flag

Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
---
M docs/topics/impala_scalability.xml
1 file changed, 34 insertions(+), 28 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/12362/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/197/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 01:49:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/196/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 02:00:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12362

to look at the new patch set (#2).

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................

IMPALA-8105: [DOCS] Document cache_remote_file_handles flag

Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
---
M docs/topics/impala_scalability.xml
1 file changed, 35 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/12362/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 4: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/208/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Feb 2019 22:09:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/204/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 20:53:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/196/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 01:42:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 4:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/208/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Feb 2019 21:46:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................

IMPALA-8105: [DOCS] Document cache_remote_file_handles flag

Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Reviewed-on: http://gerrit.cloudera.org:8080/12362
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M docs/topics/impala_scalability.xml
1 file changed, 495 insertions(+), 379 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Joe McDonnell: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12362/2/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/12362/2/docs/topics/impala_scalability.xml@911
PS2, Line 911: For
             :         example, if a query does a full table scan on a table with thousands of
             :         partitions, each partition containing multiple data files.
> This is not a complete sentence.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 20:52:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 4:

(1 comment)

One small comment, then I think this is good to go.

http://gerrit.cloudera.org:8080/#/c/12362/4/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/12362/4/docs/topics/impala_scalability.xml@924
PS4, Line 924: In Impala 3.2 and higher, you can also cache remote HDFS files handles.
             :         To prevent your NameNode from overloaded when your cluster has many
             :         remote reads, use the default setting of remote file handle caching to
             :         be <codeph>true</codeph>. You can disable remote file handle caching
             :         with the <codeph>cache_remote_file_handles</codeph> flag for an
             :           <codeph>impalad</codeph>.
Small rearrangement:

In Impala 3.2 and higher, file handle caching also applies to remote HDFS file handles. This is controlled by the <codeph>cache_remote_file_handles</codeph> flag for an <codeph>impalad</codeph>. It is recommend to use the default value of true, as this caching prevents your NameNode from overloading when your cluster has many remote HDFS reads.



-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 01:57:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12362

to look at the new patch set (#4).

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................

IMPALA-8105: [DOCS] Document cache_remote_file_handles flag

Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
---
M docs/topics/impala_scalability.xml
1 file changed, 46 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/12362/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 2:

(1 comment)

I'm in the process of changing the default value of cache_remote_file_handles from false to true. That should be up for review soon, and it would impact how we write this documentation. So, I will have more comments when that goes in.

http://gerrit.cloudera.org:8080/#/c/12362/2/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/12362/2/docs/topics/impala_scalability.xml@911
PS2, Line 911: For
             :         example, if a query does a full table scan on a table with thousands of
             :         partitions, each partition containing multiple data files.
This is not a complete sentence.

Maybe something like:
For example, a query that does a full table scan on a partitioned table may need to read thousands of partitions, each partition containing multiple data files.



-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 20:23:38 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 2:

> (1 comment)
 > 
 > I'm in the process of changing the default value of
 > cache_remote_file_handles from false to true. That should be up for
 > review soon, and it would impact how we write this documentation.
 > So, I will have more comments when that goes in.

I will wait for the update.


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 20:53:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 5: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/212/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 22:05:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/204/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 20:59:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12362

to look at the new patch set (#3).

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................

IMPALA-8105: [DOCS] Document cache_remote_file_handles flag

Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
---
M docs/topics/impala_scalability.xml
1 file changed, 35 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/12362/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12362/4/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/12362/4/docs/topics/impala_scalability.xml@924
PS4, Line 924: In Impala 3.2 and higher, you can also cache remote HDFS files handles.
             :         To prevent your NameNode from overloaded when your cluster has many
             :         remote reads, use the default setting of remote file handle caching to
             :         be <codeph>true</codeph>. You can disable remote file handle caching
             :         with the <codeph>cache_remote_file_handles</codeph> flag for an
             :           <codeph>impalad</codeph>.
> Small rearrangement:
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 21:31:47 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 5:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/212/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 21:31:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12362/5/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/12362/5/docs/topics/impala_scalability.xml@1021
PS5, Line 1021: In Impala 3.2 and higher, file handle caching also applies to remote HDFS file handles.
              :         This is controlled by the <codeph>cache_remote_file_handles</codeph> flag for an
              :         <codeph>impalad</codeph>. It is recommended that you use the default value of
              :         <codeph>true</codeph> as this caching prevents your NameNode from overloading when your
              :         cluster has many remote HDFS reads.
This is the only change you need to review. @Joe



-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 00:45:52 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/197/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 02:01:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12362

to look at the new patch set (#5).

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................

IMPALA-8105: [DOCS] Document cache_remote_file_handles flag

Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
---
M docs/topics/impala_scalability.xml
1 file changed, 495 insertions(+), 379 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/12362/5
-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 5:

It looks like the patch got auto-formatted, leading to a large diff. Can you reduce this to just the change needed?


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 00:42:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 )

Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id649e733324f55a80a0199302dfa3b627ad183cf
Gerrit-Change-Number: 12362
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 00:57:00 +0000
Gerrit-HasComments: No