You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Becky Gibson (JIRA)" <ji...@apache.org> on 2012/10/11 21:59:04 UTC
[jira] [Created] (CB-1619) Camera shutter remains closed when
returning to app
Becky Gibson created CB-1619:
--------------------------------
Summary: Camera shutter remains closed when returning to app
Key: CB-1619
URL: https://issues.apache.org/jira/browse/CB-1619
Project: Apache Cordova
Issue Type: Improvement
Components: iOS
Affects Versions: 2.1.0
Reporter: Becky Gibson
Assignee: Shazron Abdullah
Fix For: 2.2.0
Reported in the PhoneGap Group: https://groups.google.com/forum/?fromgroups=#!topic/phonegap/gXLi2ov6St4.
I can reproduce in edge verion (Oct. 11, 2012) using Mobile-spec.
1) run Mobile-spec and invoke manual camera test
2) select take picture and cancel rather than taking a picture.
3) navigate back to test list from Camera test page(may not be necessary)
4) press home button to leave app
5) open app again
6) select manual camera test
7) select take picture button and shutter does not open
in the stackoverflow discussion it was suggested that a weak reference to the UIImagePickerController rather than a strong one fixes the problem. My initial testing indicates that this is the case. Need to do more testing and code review. I suspect this also happens in capture image code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1619) Camera shutter remains closed when
returning to app
Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474515#comment-13474515 ]
Shazron Abdullah commented on CB-1619:
--------------------------------------
Since we are targeting iOS 4.2 still, we should use unsafe_unretained which is (almost) equivalent:
http://stackoverflow.com/questions/6893038/how-do-i-replace-weak-references-when-using-arc-and-targeting-ios-4-0
> Camera shutter remains closed when returning to app
> ----------------------------------------------------
>
> Key: CB-1619
> URL: https://issues.apache.org/jira/browse/CB-1619
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Becky Gibson
> Assignee: Becky Gibson
> Fix For: 2.2.0
>
>
> Reported in the PhoneGap Group: https://groups.google.com/forum/?fromgroups=#!topic/phonegap/gXLi2ov6St4.
> I can reproduce in edge verion (Oct. 11, 2012) using Mobile-spec.
> 1) run Mobile-spec and invoke manual camera test
> 2) select take picture and cancel rather than taking a picture.
> 3) navigate back to test list from Camera test page(may not be necessary)
> 4) press home button to leave app
> 5) open app again
> 6) select manual camera test
> 7) select take picture button and shutter does not open
> in the stackoverflow discussion it was suggested that a weak reference to the UIImagePickerController rather than a strong one fixes the problem. My initial testing indicates that this is the case. Need to do more testing and code review. I suspect this also happens in capture image code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CB-1619) Camera shutter remains closed when
returning to app
Posted by "Becky Gibson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Becky Gibson reassigned CB-1619:
--------------------------------
Assignee: Becky Gibson (was: Shazron Abdullah)
> Camera shutter remains closed when returning to app
> ----------------------------------------------------
>
> Key: CB-1619
> URL: https://issues.apache.org/jira/browse/CB-1619
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Becky Gibson
> Assignee: Becky Gibson
> Fix For: 2.2.0
>
>
> Reported in the PhoneGap Group: https://groups.google.com/forum/?fromgroups=#!topic/phonegap/gXLi2ov6St4.
> I can reproduce in edge verion (Oct. 11, 2012) using Mobile-spec.
> 1) run Mobile-spec and invoke manual camera test
> 2) select take picture and cancel rather than taking a picture.
> 3) navigate back to test list from Camera test page(may not be necessary)
> 4) press home button to leave app
> 5) open app again
> 6) select manual camera test
> 7) select take picture button and shutter does not open
> in the stackoverflow discussion it was suggested that a weak reference to the UIImagePickerController rather than a strong one fixes the problem. My initial testing indicates that this is the case. Need to do more testing and code review. I suspect this also happens in capture image code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1619) Camera shutter remains closed when
returning to app
Posted by "Becky Gibson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474534#comment-13474534 ]
Becky Gibson commented on CB-1619:
----------------------------------
Fix is here: https://github.com/becka11y/incubator-cordova-ios/tree/cb1619Shutter. Didn't commit to master yet as I wanted more time to test and review code.
> Camera shutter remains closed when returning to app
> ----------------------------------------------------
>
> Key: CB-1619
> URL: https://issues.apache.org/jira/browse/CB-1619
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Becky Gibson
> Assignee: Becky Gibson
> Fix For: 2.2.0
>
>
> Reported in the PhoneGap Group: https://groups.google.com/forum/?fromgroups=#!topic/phonegap/gXLi2ov6St4.
> I can reproduce in edge verion (Oct. 11, 2012) using Mobile-spec.
> 1) run Mobile-spec and invoke manual camera test
> 2) select take picture and cancel rather than taking a picture.
> 3) navigate back to test list from Camera test page(may not be necessary)
> 4) press home button to leave app
> 5) open app again
> 6) select manual camera test
> 7) select take picture button and shutter does not open
> in the stackoverflow discussion it was suggested that a weak reference to the UIImagePickerController rather than a strong one fixes the problem. My initial testing indicates that this is the case. Need to do more testing and code review. I suspect this also happens in capture image code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-1619) Camera shutter remains closed when
returning to app
Posted by "Becky Gibson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Becky Gibson resolved CB-1619.
------------------------------
Resolution: Fixed
> Camera shutter remains closed when returning to app
> ----------------------------------------------------
>
> Key: CB-1619
> URL: https://issues.apache.org/jira/browse/CB-1619
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Becky Gibson
> Assignee: Becky Gibson
> Fix For: 2.2.0
>
>
> Reported in the PhoneGap Group: https://groups.google.com/forum/?fromgroups=#!topic/phonegap/gXLi2ov6St4.
> I can reproduce in edge verion (Oct. 11, 2012) using Mobile-spec.
> 1) run Mobile-spec and invoke manual camera test
> 2) select take picture and cancel rather than taking a picture.
> 3) navigate back to test list from Camera test page(may not be necessary)
> 4) press home button to leave app
> 5) open app again
> 6) select manual camera test
> 7) select take picture button and shutter does not open
> in the stackoverflow discussion it was suggested that a weak reference to the UIImagePickerController rather than a strong one fixes the problem. My initial testing indicates that this is the case. Need to do more testing and code review. I suspect this also happens in capture image code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1619) Camera shutter remains closed when
returning to app
Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474544#comment-13474544 ]
Andrew Grieve commented on CB-1619:
-----------------------------------
Seems a bit risky to me to use unsafe_unretained to store this. Does it fix the problem if you just add the last line of your diff:
+ self.pickerController = nil;
So that we never re-use it?
> Camera shutter remains closed when returning to app
> ----------------------------------------------------
>
> Key: CB-1619
> URL: https://issues.apache.org/jira/browse/CB-1619
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Becky Gibson
> Assignee: Becky Gibson
> Fix For: 2.2.0
>
>
> Reported in the PhoneGap Group: https://groups.google.com/forum/?fromgroups=#!topic/phonegap/gXLi2ov6St4.
> I can reproduce in edge verion (Oct. 11, 2012) using Mobile-spec.
> 1) run Mobile-spec and invoke manual camera test
> 2) select take picture and cancel rather than taking a picture.
> 3) navigate back to test list from Camera test page(may not be necessary)
> 4) press home button to leave app
> 5) open app again
> 6) select manual camera test
> 7) select take picture button and shutter does not open
> in the stackoverflow discussion it was suggested that a weak reference to the UIImagePickerController rather than a strong one fixes the problem. My initial testing indicates that this is the case. Need to do more testing and code review. I suspect this also happens in capture image code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1619) Camera shutter remains closed when
returning to app
Posted by "Becky Gibson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476112#comment-13476112 ]
Becky Gibson commented on CB-1619:
----------------------------------
Good idea. That works as well. Fixed with https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=0a978a6617c58bfa98968e0c6bdcdb4f10f01902
> Camera shutter remains closed when returning to app
> ----------------------------------------------------
>
> Key: CB-1619
> URL: https://issues.apache.org/jira/browse/CB-1619
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Becky Gibson
> Assignee: Becky Gibson
> Fix For: 2.2.0
>
>
> Reported in the PhoneGap Group: https://groups.google.com/forum/?fromgroups=#!topic/phonegap/gXLi2ov6St4.
> I can reproduce in edge verion (Oct. 11, 2012) using Mobile-spec.
> 1) run Mobile-spec and invoke manual camera test
> 2) select take picture and cancel rather than taking a picture.
> 3) navigate back to test list from Camera test page(may not be necessary)
> 4) press home button to leave app
> 5) open app again
> 6) select manual camera test
> 7) select take picture button and shutter does not open
> in the stackoverflow discussion it was suggested that a weak reference to the UIImagePickerController rather than a strong one fixes the problem. My initial testing indicates that this is the case. Need to do more testing and code review. I suspect this also happens in capture image code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira