[jira] Commented: (WICKET-3184) Make method getContentId of ModalWindow static

["Vitaly Tsaplin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934749#action_12934749 ] 

Vitaly Tsaplin commented on WICKET-3184:
----------------------------------------

It may be implemented even easier and in less intrusive way. You could just introduce a public constant CONTENT_ID and getContentId would just access this constant.

> Make method getContentId of ModalWindow static
> ----------------------------------------------
>
>                 Key: WICKET-3184
>                 URL: https://issues.apache.org/jira/browse/WICKET-3184
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>            Reporter: Vitaly Tsaplin
>            Priority: Minor
>
> My proposal is to make the method getContentId of the class ModalWindow STATIC to simplify a creation of the panel class that would serve as a base class for content components. It's always necessary to specify a content ID when we create a component which can be added as a window component. This content ID can be obtained only from an instance of the modal window which often is not convenient neither neccesary since it's just a constant kept in sync with the id in the window markup. Also there is no obvious reason to override this method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.