You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shahar1 (via GitHub)" <gi...@apache.org> on 2025/08/31 19:00:10 UTC
[PR] Implement default language (English) freeze pre-commit [airflow]
shahar1 opened a new pull request, #55119:
URL: https://github.com/apache/airflow/pull/55119
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Following the recent dev call, this PR introduces a pre-commit to prevent changes in the default language during freeze time (in our case, between tomorrow Sep. 1 to Sep 8).
This pre-commit should be reused in later freezes simply by changing the dates (I'll add it to the policy).
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement default language (English) freeze pre-commit [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #55119:
URL: https://github.com/apache/airflow/pull/55119#issuecomment-3241703300
### Backport failed to create: v3-0-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/17374246360'> Run details </a>
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-0-test</td>
<td><a href="https://github.com/apache/airflow/commit/4579a382336cead8b74dc556ebd63ba0483e7bb9"><img src='https://img.shields.io/badge/Commit-4579a38-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker 4579a38 v3-0-test
```
This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement default language (English) freeze pre-commit [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 merged PR #55119:
URL: https://github.com/apache/airflow/pull/55119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement default language (English) freeze pre-commit [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #55119:
URL: https://github.com/apache/airflow/pull/55119#issuecomment-3241084151
> After a second thought, should we set time zone as AoE instead?
Nice :)
Comment: do we need the dates here at ALL ?
I think it will be enough if we just enable "freeze" in this commit and then "disable" it by a second commit after we unfroze it.
While the dates are nice from informational point of view (and we should leave them in in the messages, this one gives us extra flexibility - because we can unfreeze it deliberately rather than automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement default language (English) freeze pre-commit [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #55119:
URL: https://github.com/apache/airflow/pull/55119#issuecomment-3242893836
The simpler freeze here https://github.com/apache/airflow/pull/55154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement default language (English) freeze pre-commit [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #55119:
URL: https://github.com/apache/airflow/pull/55119#issuecomment-3241484499
sounds like a good idea 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement default language (English) freeze pre-commit [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #55119:
URL: https://github.com/apache/airflow/pull/55119#issuecomment-3241017148
> > It would be great if we can get #55041 merged before this
>
> The idea of the freeze is to align all translations against a constant source, so translation owners would be able to complete the gaps without "chasing" after the new changes every day until the release. To avoid blocking new features during this time, we could create an "exemption list" in a separate JSON file with the file names as keys. The translation owners won't be required to translate changes from this file and it will also be excluded from the completeness calculation. By the end of the freeze - we should relocate the terms from this file to their appropriate place. The trade-off for this flexibility is that terms might be missing from translations in the upcoming release, and we create a small debt to handle the list afterwards (we could relatively easily automate that).
>
> @Lee-W @kaxil @potiuk @jscheffl @bbovenzi What do you all think?
Works for me :)
> > After a second thought, should we set time zone as AoE instead?
>
> I wasn't aware that this term exists :D I'm ok with that, I assume that few hours to here and there won't make a significant difference.
I learned this from the Python community, probably EuroPython. I find it very inclusive and it makes everyone's day easier, especially in a cross-timezone community. That's why I'm kinda a promoter of this idea haha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement default language (English) freeze pre-commit [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #55119:
URL: https://github.com/apache/airflow/pull/55119#issuecomment-3240856133
After a second thought, should we set time zone as AoE instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement default language (English) freeze pre-commit [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #55119:
URL: https://github.com/apache/airflow/pull/55119#issuecomment-3240890260
> did a quick fix for the missing import
Thanks! I also realized that it didn't actually check if there was a difference in the files during these dates, so I added a "git diff" call :)
> It would be great if we can get #55041 merged before this
The idea of the freeze is to align all translations against a constant source, so translation owners would be able to complete the gaps without "chasing" after the new changes every day until the release. To avoid blocking new features during this time, we could create an "exemption list" in a separate JSON file with the file names as keys. The translation owners won't be required to translate changes from this file and it will also be excluded from the completeness calculation. By the end of the freeze - we should relocate the terms from this file to their appropriate place. The trade-off is that terms might be missing from translations in the upcoming release, and we create a small debt to handle the list afterwards (we could relatively easily automate that).
@Lee-W @kaxil @potiuk @bbovenzi What do you all think?
> After a second thought, should we set time zone as AoE instead?
I wasn't aware that this term exists :D I'm ok with that, I assume that few hours to here and there won't make a significant difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement default language (English) freeze pre-commit [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #55119:
URL: https://github.com/apache/airflow/pull/55119#issuecomment-3241699011
Thanks for the feedback, Jarek! As we discussed on Slack, converting it into a selective check would be a follow up :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement default language (English) freeze pre-commit [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #55119:
URL: https://github.com/apache/airflow/pull/55119#issuecomment-3240597333
did a quick fix for the missing import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement default language (English) freeze pre-commit [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #55119:
URL: https://github.com/apache/airflow/pull/55119#issuecomment-3241139563
Another comment. Maybe a better way would be to add the mechanism to fail and unfreeze in selective checks. We already done that in the past and it has a few nice properties:
1) It can fail FAST -> if selective checks check fails, no other job runs, the PR fails almost immediately
2) we already have "changed files" built in and we can use it from there
3) we can use "labels" to make exemptions ("allow to modify translations" for example) rather than commit "exemptions file". How it works (we do it already) - we need to set a specified label on the PR to skip the check for modified translations. So rather than finding out how to modify exemptions files,a committer has to deliberately set "allow to moify translations") to let the PR pass the selective checks.
4) you can unit test is with `test_selective_checks.py`
It's also very easy to test:
```
breeze ci selective-checks --commit-ref <HASH> --pr-labels "label"`
```
We do it already a very similar way if suspended providers are affected:
https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/utils/selective_checks.py#L1376
Some pointers how we can do it:
* add a new property in SelectiveChecks "english_translation_affected" (it will be automatically converted into output in GitHubActions
* make it return true if "en" translations are in "changed files" https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/utils/selective_checks.py#L144
* in the property method check a constant (True) in this commit "FAIL_IF_EN_TRANSLATION_MODIFIED" (for now - we can set to False when we want to disable the check) and sys.exit(1) with the right error message if en translation is in changed files unless "allow to modify translations" label is set (similarly as we do in https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/utils/selective_checks.py#L884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement default language (English) freeze pre-commit [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #55119:
URL: https://github.com/apache/airflow/pull/55119#issuecomment-3240591984
It would be great if we can get https://github.com/apache/airflow/pull/55041 merged before this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org