You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/08/05 09:11:50 UTC
[GitHub] [netbeans] sdedic opened a new pull request #3091: Indexing of inner classes/interfaces
sdedic opened a new pull request #3091:
URL: https://github.com/apache/netbeans/pull/3091
* Abstract methods were not indexed at all, since [they have no code](https://github.com/apache/netbeans/compare/delivery...sdedic:groovy/completion-inner-classes3?expand=1#diff-6ee817fd5ae2474a0c13faafb5907287e443661413bb3a5adef6c6a250280e12L303).
* Indexer did not dive [into inner types](https://github.com/apache/netbeans/compare/delivery...sdedic:groovy/completion-inner-classes3?expand=1#diff-a15c71a9d9bb85f1b65d31becc69c263b500c5c1fc6cea716b1629d4f531e08fR278),
* Navigator works bad with inner types, displayed `OuterType$InnerType`
* Variable type was obscured by assignments later than caret position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3091: Indexing of inner classes/interfaces
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3091:
URL: https://github.com/apache/netbeans/pull/3091#issuecomment-896757225
Sorry for the recommit; I've split tests for the two separate issues into individual commits. Now we have some unit tests for the fixes, too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #3091: Indexing of inner classes/interfaces
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3091:
URL: https://github.com/apache/netbeans/pull/3091#issuecomment-894292950
feel free to merge maybe one more technical reviewer agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3091: Indexing of inner classes/interfaces
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3091:
URL: https://github.com/apache/netbeans/pull/3091#issuecomment-894129711
> Need some squashing ?
Hm, each of the commits fixes/addresses a separate thing, it could be better to have them separate (for the history).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #3091: Indexing of inner classes/interfaces
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3091:
URL: https://github.com/apache/netbeans/pull/3091#issuecomment-894120064
It's mergeable because it's green but I cannot test function. Need some squashing ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #3091: Indexing of inner classes/interfaces
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #3091:
URL: https://github.com/apache/netbeans/pull/3091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists