You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/04 12:38:10 UTC

[GitHub] [airflow] ashb commented on a change in pull request #9129: Replaces cloud-provider clis in CI image with docker image aliases

ashb commented on a change in pull request #9129:
URL: https://github.com/apache/airflow/pull/9129#discussion_r435219835



##########
File path: Dockerfile.ci
##########
@@ -340,6 +308,23 @@ RUN if [[ -n "${ADDITIONAL_PYTHON_DEPS}" ]]; then \
         pip install ${ADDITIONAL_PYTHON_DEPS}; \
     fi
 
+RUN \
+    export AWSCLI_IMAGE="amazon/aws-cli:latest" && \
+    export AZURECLI_IMAGE="mcr.microsoft.com/azure-cli:latest" && \
+    export GCLOUD_IMAGE="gcr.io/google.com/cloudsdktool/cloud-sdk:latest" && \
+    echo -e "\
+    alias aws=\"docker run --rm -it -v /root/.aws:/root/.aws ${AWSCLI_IMAGE}\" \n\

Review comment:
       This volume mount is wrong. Since it is using the host's docker daemon, this will mount from /root/.aws on the host, not what /root/.aws is mounted to in this running image.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org