You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2021/03/11 11:58:16 UTC
[GitHub] [bahir-flink] YikSanChan opened a new pull request #116: [BAHIR-264] Dedup dependencies in flink-connector-redis
YikSanChan opened a new pull request #116:
URL: https://github.com/apache/bahir-flink/pull/116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] YikSanChan commented on pull request #116: [BAHIR-264] Dedup dependencies in flink-connector-redis
Posted by GitBox <gi...@apache.org>.
YikSanChan commented on pull request #116:
URL: https://github.com/apache/bahir-flink/pull/116#issuecomment-796713869
@eskabetxe done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe commented on pull request #116: [BAHIR-264] Dedup dependencies in flink-connector-redis
Posted by GitBox <gi...@apache.org>.
eskabetxe commented on pull request #116:
URL: https://github.com/apache/bahir-flink/pull/116#issuecomment-796719508
@YikSanChan thanks, waiting for tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe commented on pull request #116: [BAHIR-264] Dedup dependencies in flink-connector-redis
Posted by GitBox <gi...@apache.org>.
eskabetxe commented on pull request #116:
URL: https://github.com/apache/bahir-flink/pull/116#issuecomment-796702357
Thanks @YikSanChan for your contribution
I saw a lot of 2.11 on dependencies could you change that to
for example this
<artifactId>flink-table-api-java-bridge_2.11</artifactId>
with this
<artifactId>flink-table-api-java-bridge_${scala.binary.version}</artifactId>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] YikSanChan commented on pull request #116: [BAHIR-264] Dedup dependencies in flink-connector-redis
Posted by GitBox <gi...@apache.org>.
YikSanChan commented on pull request #116:
URL: https://github.com/apache/bahir-flink/pull/116#issuecomment-796920322
@eskabetxe thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe commented on pull request #116: [BAHIR-264] Dedup dependencies in flink-connector-redis
Posted by GitBox <gi...@apache.org>.
eskabetxe commented on pull request #116:
URL: https://github.com/apache/bahir-flink/pull/116#issuecomment-796914719
@YikSanChan merged, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe merged pull request #116: [BAHIR-264] Dedup dependencies in flink-connector-redis
Posted by GitBox <gi...@apache.org>.
eskabetxe merged pull request #116:
URL: https://github.com/apache/bahir-flink/pull/116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org