You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/21 19:22:02 UTC
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4094: kvm: qemu-img convert -s to backup snapshot is deprecated
DaanHoogland commented on a change in pull request #4094:
URL: https://github.com/apache/cloudstack/pull/4094#discussion_r428862371
##########
File path: scripts/storage/qcow2/managesnapshot.sh
##########
@@ -153,7 +153,7 @@ destroy_snapshot() {
lvm lvremove -f "${vg}/${snapshotname}-cow"
elif [ -f $disk ]; then
#delete all the existing snapshots
- $qemu_img snapshot -l $disk |tail -n +3|awk '{print $1}'|xargs -I {} $qemu_img snapshot -d {} $disk >&2
+ $qemu_img snapshot -l $disk |tail -n +3|awk '{print $2}'|xargs -I {} $qemu_img snapshot -d {} $disk >&2
Review comment:
@rhtyd from [the qemu wiki](https://wiki.qemu.org/Features/SnapshottingImprovements) :
```
$ qemu-img snapshot -l xxtest.qcow2
Snapshot list:
ID TAG VM SIZE DATE VM CLOCK
1 1.5M 2010-07-26 16:51:52 00:00:08.599
2 1.5M 2010-07-26 16:51:53 00:00:09.719
3 1.5M 2010-07-26 17:26:49 00:00:13.245
4 1.5M 2010-07-26 19:01:00 00:00:46.763
```
no name to be found.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org