[GitHub] [pulsar] nodece commented on a diff in pull request #17722: support setting bundle number for default namespace when set up cluster

[GitBox <gi...@apache.org>]

nodece commented on code in PR #17722:
URL: https://github.com/apache/pulsar/pull/17722#discussion_r976004193


##########
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java:
##########
@@ -63,10 +66,18 @@
  */
 public class PulsarClusterMetadataSetup {
 
+    private static final int DEFAULT_BUNDLE_NUMBER = 16;
+
     private static class Arguments {
         @Parameter(names = { "-c", "--cluster" }, description = "Cluster name", required = true)
         private String cluster;
 
+        @Parameter(names = {"-bc", "--broker-conf"},
+                description = "Configuration file for Broker to get the default bundle numbers "
+                        + "for public/default namespace")
+        private String brokerConfigFile =
+                Paths.get("").toAbsolutePath().normalize().toString() + "/conf/broker.conf";

Review Comment:
   Do we need this value? This will break the `DEFAULT_BUNDLE_NUMBER`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org