You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hudson (Commented) (JIRA)" <ji...@apache.org> on 2012/02/08 01:46:59 UTC

[jira] [Commented] (HADOOP-7813) test-patch +1 patches that introduce javadoc and findbugs warnings in some cases

    [ https://issues.apache.org/jira/browse/HADOOP-7813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203044#comment-13203044 ] 

Hudson commented on HADOOP-7813:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1760 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1760/])
    HADOOP-7813. Added to CHANGES.txt

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241714
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

                
> test-patch +1 patches that introduce javadoc and findbugs warnings in some cases
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-7813
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7813
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build, test
>    Affects Versions: 0.24.0, 0.23.1
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>             Fix For: 0.24.0, 0.23.1
>
>         Attachments: HADOOP-7813.patch
>
>
> test-patch.sh uses string comparisons of numbers to decide whether to +1 for javadoc and findbugs warnings.
> decisions are made using the following construct
> [[ $A > $B ]] 
> Brackets put the script into conditional expression mode 
> Operator definition for  conditional expression mode
>        string1 > string2
>               True if string1 sorts after string2 lexicographically in the current locale.
> Examples
> $ sh -c 'if [[ 99 > 100 ]]; then echo true; fi'
> true
> $ sh -c 'if [[ -99 > -10 ]]; then echo true; fi'
> true
> Arithmetic operations in conditional expressions are defined below
>        arg1 OP arg2
>               OP is one of -eq, -ne, -lt, -le, -gt, or -ge.  These arithmetic binary operators return true if arg1 is equal to, not equal to, less than, less than or equal to, greater  than,  or  greater  than  or equal to arg2, respectively.  Arg1 and arg2 may be positive or negative integers.
> Alternatively arithmetic evaluation mode can be entered using double parenthesis "(( .. ))"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira