You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zentol (via GitHub)" <gi...@apache.org> on 2023/06/15 13:10:52 UTC
[GitHub] [flink] zentol opened a new pull request, #22792: [FLINK-25000][build] Java 17 uses Scala 2.12.15
zentol opened a new pull request, #22792:
URL: https://github.com/apache/flink/pull/22792
Based on #22780.
Since Scala 2.12.7 doesn't compile we will run the build with a later version of Scala when running on Java 17. This breaks various compatibility tests which are now disable in Java 17 builds, and I don't see a way around that.
Note that compiled 2.12.7 Scala code does appear to run on Java 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #22792: [FLINK-25000][build] Java 17 uses Scala 2.12.15
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol merged PR #22792:
URL: https://github.com/apache/flink/pull/22792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22792: [FLINK-25000][build] Java 17 uses Scala 2.12.15
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22792:
URL: https://github.com/apache/flink/pull/22792#issuecomment-1593041863
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "baea61f3e55e790e63f5e84d02a58c9fc5174291",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "baea61f3e55e790e63f5e84d02a58c9fc5174291",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* baea61f3e55e790e63f5e84d02a58c9fc5174291 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #22792: [FLINK-25000][build] Java 17 uses Scala 2.12.15
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22792:
URL: https://github.com/apache/flink/pull/22792#discussion_r1231140744
##########
flink-scala/pom.xml:
##########
@@ -328,5 +328,20 @@ under the License.
</plugins>
</build>
</profile>
+ <profile>
+ <id>java17</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.github.zentol.japicmp</groupId>
+ <artifactId>japicmp-maven-plugin</artifactId>
+ <configuration>
+ <!-- version bump broke the checks -->
+ <skip>true</skip>
Review Comment:
This currently doesn't to have any effect; investigating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org