[jira] [Commented] (TEZ-3958) Add internal vertex priority information into the tez dag.dot debug information

["TezQA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531962#comment-16531962 ] 

TezQA commented on TEZ-3958:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12929991/TEZ-3958.1.patch
  against master revision 06757e9.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
                   org.apache.tez.dag.app.dag.impl.TestDAGScheduler
                  org.apache.tez.test.TestRecovery

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2850//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/2850//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2850//console

This message is automatically generated.


> Add internal vertex priority information into the tez dag.dot debug information
> -------------------------------------------------------------------------------
>
>                 Key: TEZ-3958
>                 URL: https://issues.apache.org/jira/browse/TEZ-3958
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Gopal V
>            Assignee: Jaume M
>            Priority: Major
>         Attachments: TEZ-3958.1.patch
>
>
> Adding the actual vertex priority as computed by Tez into the debug dag.dot file would allows the debugging of task pre-emption issues when the DAG is no longer a tree.
> There are pre-emption issues with isomerization of Tez DAGs, where the a R-isomer dag with mirror rotation runs at a different speed than the L-isomer dag, due to priorities at the same level changing due to the vertex-id order.
> Since the problem is hard to debug through, it would be good to record the computed priority in the DAG .dot file in the logging directories.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)