You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "bito-code-review[bot] (via GitHub)" <gi...@apache.org> on 2026/06/04 16:36:18 UTC

Re: [PR] fix(database): preserve engine_information when creating database connection [superset]

bito-code-review[bot] commented on PR #38107:
URL: https://github.com/apache/superset/pull/38107#issuecomment-4624193896

   <!-- Bito Reply -->
   The suggestion is appropriate as it improves the maintainability of the test by decoupling the comment from the specific enum key. This ensures the test documentation remains accurate even if the underlying action type is renamed. You should apply this change to improve code clarity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org