[GitHub] [beam] lukecwik commented on a diff in pull request #22645: [BEAM-12776, fixes #21095] Limit parallel closes from the prior element to the next element.

[GitBox <gi...@apache.org>]

lukecwik commented on code in PR #22645:
URL: https://github.com/apache/beam/pull/22645#discussion_r948485957


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java:
##########
@@ -996,10 +1001,18 @@ public void finishBundle(FinishBundleContext c) throws Exception {
           c.output(result.getValue(), result.getKey(), result.getValue().getWindow());
         }
       } finally {
-        deferredOutput = null;
-        closeFutures = null;
+        deferredOutput.clear();
+        closeFutures.clear();
       }
     }
+
+    // Ensure that transient fields are initialized.

Review Comment:
   I forgot about `@Setup`. Swapped to using it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org