[GitHub] [doris] cambyzju commented on a diff in pull request #13440: [Function](array) support array_difference function

[GitBox <gi...@apache.org>]

cambyzju commented on code in PR #13440:
URL: https://github.com/apache/doris/pull/13440#discussion_r999365535


##########
be/src/vec/functions/array/function_array_difference.h:
##########
@@ -0,0 +1,204 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "vec/columns/column.h"
+#include "vec/columns/column_array.h"
+#include "vec/core/types.h"
+#include "vec/data_types/data_type.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_nullable.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/utils/util.hpp"
+
+namespace doris::vectorized {
+
+class FunctionArrayDifference : public IFunction {
+public:
+    static constexpr auto name = "array_difference";
+
+    static FunctionPtr create() { return std::make_shared<FunctionArrayDifference>(); }
+
+    String get_name() const override { return name; }
+
+    bool is_variadic() const override { return false; }
+
+    size_t get_number_of_arguments() const override { return 1; }
+
+    bool use_default_implementation_for_nulls() const override { return true; }
+
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+        DCHECK(is_array(arguments[0]))
+                << "argument for function: " << name << " should be DataTypeArray but it has type "
+                << arguments[0]->get_name() << ".";
+        auto nested_type = assert_cast<const DataTypeArray&>(*(arguments[0])).get_nested_type();
+        bool is_nullable = nested_type->is_nullable();
+
+        WhichDataType which(remove_nullable(nested_type));
+        //return type is promoted to prevent result overflow
+        //like: input is int32 ---> return type will be int64
+        DataTypePtr return_type = nullptr;
+        if (which.is_uint8() || which.is_int8()) {
+            return_type = std::make_shared<DataTypeInt16>();
+        } else if (which.is_uint16() || which.is_int16()) {
+            return_type = std::make_shared<DataTypeInt32>();
+        } else if (which.is_uint32() || which.is_uint64() || which.is_int32()) {
+            return_type = std::make_shared<DataTypeInt64>();
+        } else if (which.is_int64() || which.is_int128()) {
+            return_type = std::make_shared<DataTypeInt128>();
+        } else if (which.is_float32() || which.is_float64()) {
+            return_type = std::make_shared<DataTypeFloat64>();
+        } else if (which.is_decimal()) {
+            return arguments[0];
+        }
+        return std::make_shared<DataTypeArray>(is_nullable ? make_nullable(return_type)

Review Comment:
   if return_type is nullptr, we should just return nullptr



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org