[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8770: Re-enable pylint for some model files

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #8770: Re-enable pylint for some model files
URL: https://github.com/apache/incubator-superset/pull/8770#discussion_r355066583
 
 

 ##########
 File path: .pylintrc
 ##########
 @@ -115,7 +115,7 @@ evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / stateme
 [BASIC]
 
 # Good variable names which should always be accepted, separated by a comma
-good-names=i,j,k,ex,Run,_,d,e,v,o,l,x,ts,f
+good-names=i,j,k,ex,Run,_,d,e,v,o,l,x,ts,f,id
 
 Review comment:
   `id` is not ok as it would shadow the globally scoped python `id` function.
   ```
   In [1]: id?
   Signature: id(obj, /)
   Docstring:
   Return the identity of an object.
   
   This is guaranteed to be unique among simultaneously existing objects.
   (CPython uses the object's memory address.)
   Type:      builtin_function_or_method
   
   In [2]: id('')
   Out[2]: 4401957552
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org