You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "giftig (via GitHub)" <gi...@apache.org> on 2023/04/20 11:34:53 UTC

[GitHub] [superset] giftig commented on pull request #21535: fix(parsedquery): resolve conflict when aliases and tables have the same name

giftig commented on PR #21535:
URL: https://github.com/apache/superset/pull/21535#issuecomment-1516175643

   Hi @zhaoyongjie @john-bodley @michael-s-molina I'm looking to upgrade to the superset 2.1 release but we've had to make a number of small patches and security fixes to our fork of the 2.0 release patch issues such as this one, which was contributed here by a former member of our team.
   
   I'm trying to figure out if this patch is still needed or if a similar fix has made it into the 2.1 release as there hasn't been any activity on the issue or PR here. Are you able to confirm whether the issue described here has been resolved?
   
   We'd also be interested in any guidance you can offer in how we can avoid straying too far from what's being worked on by the open source team. What we'd really like to do is work with your team to find sensible ways of discussing and contributing some of the features and short-term fixes we've made back to the project for the benefit of both our organisation and the wider community. As we've been working at a fairly fast pace we've unfortunately diverged to get patches and customisations in quick and avoid waiting for releases, and we haven't previously allowed time to reach out to your team to see what we can give back other than by raising a couple of PRs like this one. We'll try to reach out via your slack and discuss a way forward, but wanted to add a heads up here in case you can advise who best to speak to and how best to get in touch.
   
   Apologies for tagging you directly, I took your names from the top recent contributor list, and saw @zhaoyongjie previosuly had eyes on this PR :eyes: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org