[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #221: feat: Include dictionary member in `ArrowArrayView` struct

["paleolimbot (via GitHub)" <gi...@apache.org>]

paleolimbot commented on code in PR #221:
URL: https://github.com/apache/arrow-nanoarrow/pull/221#discussion_r1224382025


##########
src/nanoarrow/array.c:
##########
@@ -168,21 +168,40 @@ ArrowErrorCode ArrowArrayInitFromType(struct ArrowArray* array,
 ArrowErrorCode ArrowArrayInitFromArrayView(struct ArrowArray* array,
                                            struct ArrowArrayView* array_view,
                                            struct ArrowError* error) {
-  ArrowArrayInitFromType(array, array_view->storage_type);
+  NANOARROW_RETURN_NOT_OK_WITH_ERROR(
+      ArrowArrayInitFromType(array, array_view->storage_type), error);

Review Comment:
   Good idea! I will target that for 0.3 (mostly to avoid wreaking havoc on any existing usage): https://github.com/apache/arrow-nanoarrow/issues/224



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org