[GitHub] erisu opened a new pull request #490: WIP: Fixes build & run related bugs from builder refactor

[GitBox <gi...@apache.org>]

erisu opened a new pull request #490: WIP: Fixes build & run related bugs from builder refactor
URL: https://github.com/apache/cordova-android/pull/490
 
 
   ### Platforms affected
   Android
   
   ### What does this PR do?
   Fixes, refactors, and improves the build and run process that came from the builder refactor.
   
   - General Code Refactor
   - Removed builder type argument from getBuilder API
   - Removed any reference of conditional statements around builder type
   - Remove plugin handler install and uninstall option flag android_studio
   - Remove --gradle flag references
   - Fixed plugin handler install and uninstall pathing issues
   - Use the nobuild flag option to control the run build.
   - Updated test spec to reflect the changes.
   
   ### What testing has been done on this change?
   **General Tests**
   - [x] `npm test`
   - [x] `npm run eslint`
   
   **Default Template**
   - [ ] `cordova build android`
   - [ ] `cordova build android --release --device`
   - [ ] `cordova build android --debug --device`
   - [ ] `cordova run android --emulator`
   - [ ] `cordova prepare android`
   - [ ] `cordova compile android`
   
   ### Checklist
   - [x] Updated automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org