[GitHub] [iceberg] rdblue commented on a diff in pull request #4011: Allow table defaults to be configured and/ or enforced at catalog level using catalog properties.

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4011:
URL: https://github.com/apache/iceberg/pull/4011#discussion_r875323901


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -162,6 +164,13 @@ private FileIO initializeFileIO(Map<String, String> properties) {
     }
   }
 
+  @VisibleForTesting
+  void initialize(String name, String path, AwsProperties properties, GlueClient client,
+      LockManager lock, FileIO io, Map<String, String> catalogProps) {

Review Comment:
   Agreed. The starting indent of all argument lines should match. That could be starting after `initialize(` or using a continuation indent on the following line. But the important thing is that all lines with arguments indent arguments at the same place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org