You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/04/02 04:08:20 UTC

[GitHub] [zookeeper] hanm commented on issue #724: ZOOKEEPER-2488: Synchronized access to shuttingDownLE in QuorumPeer

hanm commented on issue #724: ZOOKEEPER-2488: Synchronized access to shuttingDownLE in QuorumPeer
URL: https://github.com/apache/zookeeper/pull/724#issuecomment-607609426
 
 
   patch LGTM; synchronized on `QuorumPeer` when accessing `shuttingDownLE` is easy to reason and understand over other solutions like making  `shuttingDownLE` volatile, which might work but is not so obvious and sounds fragile if access pattern or other parts of the code changed in future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services