[GitHub] [incubator-doris] imay commented on a change in pull request #1854: Avoid SerDe for aggregation query with object pool

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1854: Avoid SerDe for aggregation query with object pool
URL: https://github.com/apache/incubator-doris/pull/1854#discussion_r327549778
 
 

 ##########
 File path: be/src/olap/schema_change.cpp
 ##########
 @@ -578,7 +579,7 @@ bool RowBlockMerger::merge(
 
     row_cursor.allocate_memory_for_string_type(_tablet->tablet_schema());
     while (_heap.size() > 0) {
-        init_row_with_others(&row_cursor, *(_heap.top().row_cursor), arena.get());
+        init_row_with_others(&row_cursor, *(_heap.top().row_cursor), arena.get(), agg_object_pool.get());
 
 Review comment:
   reset object pool like arena?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org