You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/13 04:17:34 UTC
[GitHub] [pulsar] liangyepianzhou opened a new pull request, #17746: [fix][flaky-test] Fix TransactionTest failure due to clean up after class
liangyepianzhou opened a new pull request, #17746:
URL: https://github.com/apache/pulsar/pull/17746
### Motivation
Fix `testGetTxnID`: transaction Id is not begin at 0;
`testSubscriptionRecreateTopic` : topic is already exsit.
and `testPendingAckMarkDeletePosition`: failed to get TP manager stats due to `testEndTPRecoveringWhenManagerLedgerDisReadable` set a mock 'TransactionPendingAckStoreProvider' into pulsar.
### Modification
fix them.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
### Matching PR in forked repository
PR in forked repository: https://github.com/liangyepianzhou/pulsar/pull/3
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #17746: [fix][flaky-test] Fix TransactionTest failure due to clean up after class
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #17746:
URL: https://github.com/apache/pulsar/pull/17746#issuecomment-1259317621
@liangyepianzhou We should reduce the `beforeMethod` `afterMethod`, it will slow down the test, and waste the CI resources. The fix looks like moving some test from the `beforeClass` and `afterClass` to `beforeMethod` `afterMethod`. I think the right way is to make the test can work with `beforeClass` and `afterClass`, you can use `beforeMethod` and `afterMethod` to clean some metadata and data by using Pulsar Admin API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #17746: [fix][flaky-test] Fix TransactionTest failure due to clean up after class
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #17746: [fix][flaky-test] Fix TransactionTest failure due to clean up after class
URL: https://github.com/apache/pulsar/pull/17746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou closed pull request #17746: [fix][txn] Fix TransactionTest for BeforeClass
Posted by GitBox <gi...@apache.org>.
liangyepianzhou closed pull request #17746: [fix][txn] Fix TransactionTest for BeforeClass
URL: https://github.com/apache/pulsar/pull/17746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #17746: [fix][test] Fix TransactionTest failure due to clean up after class
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17746:
URL: https://github.com/apache/pulsar/pull/17746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #17746: [fix][test] Fix TransactionTest failure due to clean up after class
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17746:
URL: https://github.com/apache/pulsar/pull/17746#issuecomment-1277019374
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/17746?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@c952f3c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/17746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17746 +/- ##
=========================================
Coverage ? 70.92%
Complexity ? 437
=========================================
Files ? 26
Lines ? 2246
Branches ? 245
=========================================
Hits ? 1593
Misses ? 480
Partials ? 173
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `70.92% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org