[GitHub] [spark] hvanhovell commented on a diff in pull request #40160: [CONNECT] Eager Execution of DF.sql()

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #40160:
URL: https://github.com/apache/spark/pull/40160#discussion_r1118779457


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala:
##########
@@ -59,6 +56,7 @@ import org.apache.spark.unsafe.types.CalendarInterval
 // scalastyle:on
 class PlanGenerationTestSuite
     extends ConnectFunSuite
+    with RemoteSparkSession

Review Comment:
   The whole point of this test was not to use a remote session. Can we just move the test to sql to ClientE2ETestSuite?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org