You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Shai Erera <se...@gmail.com> on 2008/12/22 07:46:56 UTC
IndexFileNameFilter
Hi
Is IndexFileNameFilter supposed to be a singleton (looks like it)?
If so, shouldn't its constructor be private?
Also, since it has a static getFilter() method, its singleton should also be
private.
I checked and there are no references to either the singleton or the
constructor outside this class, so the change should not cause any issues.
Shai
Re: IndexFileNameFilter
Posted by Shai Erera <se...@gmail.com>.
Sure
On Mon, Dec 22, 2008 at 1:37 PM, Michael McCandless <
lucene@mikemccandless.com> wrote:
>
> I think this makes sense. Can you submit patch? Thanks Shai.
>
> Mike
>
>
> Shai Erera wrote:
>
> Hi
>>
>> Is IndexFileNameFilter supposed to be a singleton (looks like it)?
>> If so, shouldn't its constructor be private?
>> Also, since it has a static getFilter() method, its singleton should also
>> be private.
>> I checked and there are no references to either the singleton or the
>> constructor outside this class, so the change should not cause any issues.
>>
>> Shai
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
Re: IndexFileNameFilter
Posted by Michael McCandless <lu...@mikemccandless.com>.
I think this makes sense. Can you submit patch? Thanks Shai.
Mike
Shai Erera wrote:
> Hi
>
> Is IndexFileNameFilter supposed to be a singleton (looks like it)?
> If so, shouldn't its constructor be private?
> Also, since it has a static getFilter() method, its singleton should
> also be private.
> I checked and there are no references to either the singleton or the
> constructor outside this class, so the change should not cause any
> issues.
>
> Shai
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org