You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2014/12/01 12:13:13 UTC

[jira] [Reopened] (THRIFT-2859) JSON generator: output complete descriptors

     [ https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer reopened THRIFT-2859:
--------------------------------

Something is wrong here:

{code}
/home/jenkins/jenkins-slave/workspace/Thrift-Compiler-Windows/compiler/cpp/src/generate/t_json_generator.cc: In member function 'void t_json_generator::write_key_and_integer(std::string, int)':
/home/jenkins/jenkins-slave/workspace/Thrift-Compiler-Windows/compiler/cpp/src/generate/t_json_generator.cc:195: error: 'to_string' is not a member of 'std'
/home/jenkins/jenkins-slave/workspace/Thrift-Compiler-Windows/compiler/cpp/src/generate/t_json_generator.cc: In member function 'void t_json_generator::write_integer(long int)':
/home/jenkins/jenkins-slave/workspace/Thrift-Compiler-Windows/compiler/cpp/src/generate/t_json_generator.cc:432: error: 'to_string' is not a member of 'std'
/home/jenkins/jenkins-slave/workspace/Thrift-Compiler-Windows/compiler/cpp/src/generate/t_json_generator.cc: In member function 'void t_json_generator::write_double(double)':
/home/jenkins/jenkins-slave/workspace/Thrift-Compiler-Windows/compiler/cpp/src/generate/t_json_generator.cc:436: error: 'to_string' is not a member of 'std'
/home/jenkins/jenkins-slave/workspace/Thrift-Compiler-Windows/compiler/cpp/src/generate/t_json_generator.cc: In member function 'void t_json_generator::write_const_value(t_const_value*, bool)':
/home/jenkins/jenkins-slave/workspace/Thrift-Compiler-Windows/compiler/cpp/src/generate/t_json_generator.cc:446: error: 'to_string' is not a member of 'std'
/home/jenkins/jenkins-slave/workspace/Thrift-Compiler-Windows/compiler/cpp/src/generate/t_json_generator.cc:454: error: 'to_string' is not a member of 'std'
make[2]: *** [CMakeFiles/thrift.dir/src/generate/t_json_generator.cc.obj] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/thrift.dir/all] Error 2
{code}



> JSON generator: output complete descriptors
> -------------------------------------------
>
>                 Key: THRIFT-2859
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2859
>             Project: Thrift
>          Issue Type: Improvement
>          Components: JSON - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Stig Bakken
>            Assignee: Jens Geyer
>            Priority: Minor
>             Fix For: 0.9.3
>
>
> (Someone should probably add a Jira component for the JSON generator.)
> The attached pull request contains some improvements to the JSON generator:
> 1. programs are no longer merged by default, use "--gen json:merge"
> 2. "index" is renamed to "key" for fields to match the compiler's internal naming
> 3. types are described in a way that does not require string parsing
> 4. full support for exceptions, unions, namespaces, includes and required/optional fields



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)