[jira] [Resolved] (PDFBOX-1596) OverlayPDF logic should be moved into a library class

["Andreas Lehmkühler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PDFBOX-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Lehmkühler resolved PDFBOX-1596.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0
                   1.8.6

I've added the patch in revisions http://svn.apache.org/r1602255 (trunk) and http://svn.apache.org/r1602258 (1.8 branch) with some slight changes.

Thanks for the contribution and your patience!

> OverlayPDF logic should be moved into a library class
> -----------------------------------------------------
>
>                 Key: PDFBOX-1596
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1596
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 1.8.1
>            Reporter: James Green
>            Assignee: Andreas Lehmkühler
>            Priority: Minor
>             Fix For: 1.8.6, 2.0.0
>
>         Attachments: PDFBOX-1596.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> We're finding that the OverlayPDF command line utility fixes problems observed when using the Overlay class. However, with the Overlay class we can operate it as a library call, but the OverlayPDF command line utility can't be, particularly given we work with PDDocuments.
> I've just had someone copy the entire OverlayPDF class into one of our own and modify it to accept pre-loaded PDDocuments instead of filenames. It would be far more constructive to extract the core logic into a library class and have the CLI class drive it.
> If we had a proper clone method it would be good to create a completely new PDDocument to serve as the new returned document instead of mutating the inputs too...



--
This message was sent by Atlassian JIRA
(v6.2#6252)