[jira] [Created] (HBASE-7859) errors from creating ZK offline node are not handled

["Sergey Shelukhin (JIRA)" <ji...@apache.org>]

Sergey Shelukhin created HBASE-7859:
---------------------------------------

             Summary: errors from creating ZK offline node are not handled
                 Key: HBASE-7859
                 URL: https://issues.apache.org/jira/browse/HBASE-7859
             Project: HBase
          Issue Type: Bug
            Reporter: Sergey Shelukhin


Quote from HBASE-7799
{quote}
Debugging the code and reproduced the problem.
What i observed was

{code}
try {
      ZKAssign.asyncCreateNodeOffline(watcher, state.getRegion(),
        destination, cb, state);
    } catch (KeeperException e) {
      if (e instanceof NodeExistsException) {
        LOG.warn("Node for " + state.getRegion() + " already exists");
      } else {
        server.abort("Unexpected ZK exception creating/setting node OFFLINE", e);
      }
      return false;
    }
return true;
{code}

The asyncCreateNodeOffline just always returns true because it does not wait for the callback to take action. Also the callback does not throw NodeExistsException.
{quote}
In short the catch block is a dead code. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira