You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2026/02/17 04:34:12 UTC
[PR] RATIS-2412. NettyClient LoggingHandler not working. [ratis]
slfan1989 opened a new pull request, #1353:
URL: https://github.com/apache/ratis/pull/1353
## What changes were proposed in this pull request?
### Root Cause
The `Bootstrap.handler()` method stores the handler in a single field. Each call overwrites the previous value instead of appending. As a result, only the last handler (initializer) is applied, and LoggingHandler is completely ignored.
### Solution
Combine both handlers into a single `ChannelInitializer` that adds LoggingHandler to the pipeline first, then delegates to the original initializer:
## What is the link to the Apache JIRA
RATIS-2412. NettyClient LoggingHandler not working.
## How was this patch tested?
- Exist Junit Test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2412. NettyClient LoggingHandler not working. [ratis]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #1353:
URL: https://github.com/apache/ratis/pull/1353#issuecomment-3923846467
> +1 the change looks good.
@szetszwo Thanks a lot for reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2412. NettyClient LoggingHandler not working. [ratis]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #1353:
URL: https://github.com/apache/ratis/pull/1353#issuecomment-3922924643
> @slfan1989 , thanks for working on this! Good catch on the bug.
>
> * Let's add it in the `initializer`, see below.
> * BTW, it currently uses LogLevel.INFO. Would it print a lot messages? Since this is client, how about changing it to WARN?
@szetszwo Thanks for reviewing the code!
Sure, I'll add it to the initializer. You're right, INFO is too noisy for client-side. Switching to WARN now — thanks for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2412. NettyClient LoggingHandler not working. [ratis]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #1353:
URL: https://github.com/apache/ratis/pull/1353#issuecomment-3913140750
@szetszwo Could you please review this PR? Thanks so much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2412. NettyClient LoggingHandler not working. [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo merged PR #1353:
URL: https://github.com/apache/ratis/pull/1353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org