[GitHub] [hudi] danny0405 commented on a diff in pull request #7189: [HUDI-5159]Add support write success file to finished partition in flink streaming append write

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #7189:
URL: https://github.com/apache/hudi/pull/7189#discussion_r1022374084


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/BulkInsertWriterHelper.java:
##########
@@ -212,5 +212,17 @@ private static WriteStatus toWriteStatus(HoodieInternalWriteStatus internalWrite
     writeStatus.setTotalErrorRecords(internalWriteStatus.getTotalErrorRecords());
     return writeStatus;
   }
+
+  /**
+   * Get partition path from the record.
+   * @param record
+   * @return
+   */
+  public String getPartitionPath(RowData record) {
+    if (keyGen == null) {
+      return null;
+    }

Review Comment:
   We can still fetch the partition path if the keygen is not null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org