[GitHub] [commons-bcel] euske commented on a change in pull request #36: Made some variable names more consistent with the other parts.

[GitBox <gi...@apache.org>]

euske commented on a change in pull request #36: Made some variable names more consistent with the other parts.
URL: https://github.com/apache/commons-bcel/pull/36#discussion_r337066366
 
 

 ##########
 File path: src/main/java/org/apache/bcel/classfile/LocalVariableTypeTable.java
 ##########
 @@ -67,8 +67,8 @@ public LocalVariableTypeTable(final int name_index, final int length, final Loca
         this.local_variable_type_table = local_variable_table;
     }
 
-    LocalVariableTypeTable(final int nameIdx, final int len, final DataInput input, final ConstantPool cpool) throws IOException {
-        this(nameIdx, len, (LocalVariable[]) null, cpool);
+    LocalVariableTypeTable(final int name_index, final int length, final DataInput input, final ConstantPool cpool) throws IOException {
+        this(name_index, length, (LocalVariable[]) null, cpool);
 
 Review comment:
   Although I'm not insisting, *_index is a pretty common naming scheme throughout the project (about 600 instances). Actually *idx is common too (about 200 instances), but the other constructor in this class already uses name_index as an argument, so I thought this change fits more naturally than the other way around.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services