You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "ParkGyeongTae (via GitHub)" <gi...@apache.org> on 2026/07/10 23:28:06 UTC

[PR] [ZEPPELIN-6512] Fix typos in variable names and log messages in terminal classes [zeppelin]

ParkGyeongTae opened a new pull request, #5286:
URL: https://github.com/apache/zeppelin/pull/5286

   ### What is this PR for?
   Fix typos in variable/parameter names and log messages across the terminal interpreter classes.
   The changes are purely cosmetic — no logic is altered.
   
   - `Cann't` → `Can't` in log messages (TerminalManager.java, 4 occurrences)
   - `Unrecodnized` → `Unrecognized` in log message (TerminalSocket.java)
   - `allwedOrigin` → `allowedOrigin` for field and parameter names (TerminalThread.java)
   - `keyPrex` → `keyPrefix` for local variable name (TerminalManager.java)
   - `nodeId` → `noteId` for parameter name to match actual semantics (TerminalManager.java)
   
   ### What type of PR is it?
   Improvement
   
   ### Todos
   * [x] Fix typos in log messages
   * [x] Fix typos in variable/field/parameter names
   * [x] Correct semantic naming (`nodeId` → `noteId`)
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-6512
   
   ### How should this be tested?
   No logic changes are made. Verify that the terminal interpreter starts and operates normally:
   1. Launch Zeppelin with the Shell interpreter.
   2. Open a note and run a `%sh.terminal` paragraph.
   3. Confirm the terminal connects and responds without errors.
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6512] Fix typos in variable names and log messages in terminal classes [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5286:
URL: https://github.com/apache/zeppelin/pull/5286#issuecomment-4951627299

   Merged into master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6512] Fix typos in variable names and log messages in terminal classes [zeppelin]

Posted by "devyeony (via GitHub)" <gi...@apache.org>.
devyeony commented on PR #5286:
URL: https://github.com/apache/zeppelin/pull/5286#issuecomment-4944644633

   LGTM :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6512] Fix typos in variable names and log messages in terminal classes [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee merged PR #5286:
URL: https://github.com/apache/zeppelin/pull/5286


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org