You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/01/12 00:12:12 UTC
Review Request 69729: Removed unused class fields in the allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69729/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/allocator/allocator.hpp b58371b5247c6a479b10b6967ef852801081e6e8
src/master/allocator/mesos/hierarchical.hpp a4425bc952864d6a0dacee4ae92637fd31e4a45f
Diff: https://reviews.apache.org/r/69729/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 69729: Removed unused class fields in the
allocator.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On Jan. 11, 2019, 6:15 p.m., Benjamin Mahler wrote:
> > Seems useful to add a bit of context to the description that these are now duplicated via the options struct and used through that? Did I understand right?
That is correct. Updated the summary.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69729/#review211932
-----------------------------------------------------------
On Jan. 11, 2019, 4:12 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69729/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 4:12 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These fields were used before we introducing the
> `mesos::allocator::Options` struct. They are now
> duplicated and unused.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp b58371b5247c6a479b10b6967ef852801081e6e8
> src/master/allocator/mesos/hierarchical.hpp a4425bc952864d6a0dacee4ae92637fd31e4a45f
>
>
> Diff: https://reviews.apache.org/r/69729/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 69729: Removed unused class fields in the
allocator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69729/#review211932
-----------------------------------------------------------
Ship it!
Seems useful to add a bit of context to the description that these are now duplicated via the options struct and used through that? Did I understand right?
- Benjamin Mahler
On Jan. 12, 2019, 12:12 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69729/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2019, 12:12 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp b58371b5247c6a479b10b6967ef852801081e6e8
> src/master/allocator/mesos/hierarchical.hpp a4425bc952864d6a0dacee4ae92637fd31e4a45f
>
>
> Diff: https://reviews.apache.org/r/69729/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 69729: Removed unused class fields in the
allocator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69729/#review211933
-----------------------------------------------------------
PASS: Mesos patch 69729 was successfully built and tested.
Reviews applied: `['69729']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2770/mesos-review-69729
- Mesos Reviewbot Windows
On Jan. 11, 2019, 4:12 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69729/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 4:12 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp b58371b5247c6a479b10b6967ef852801081e6e8
> src/master/allocator/mesos/hierarchical.hpp a4425bc952864d6a0dacee4ae92637fd31e4a45f
>
>
> Diff: https://reviews.apache.org/r/69729/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>