You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2016/04/29 14:56:48 UTC
Review Request 46831: takeover_config_merge.py should capture 'final'
config attributes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46831/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-16161
https://issues.apache.org/jira/browse/AMBARI-16161
Repository: ambari
Description
-------
`takeover_config_merge.py` when parsing config files should capture the
_final_ flag from the XML files and set them in the config attributes in
generated blueprint. They can be specified in the blueprint as:
"configuration-type" : {
"properties_attributes": {
"property-name1" : "property-value"
},
"properties": {
"property-name2" : "property-value"
}
}
Diffs
-----
ambari-server/src/main/resources/scripts/takeover_config_merge.py 8f11db4
Diff: https://reviews.apache.org/r/46831/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 46831: takeover_config_merge.py should capture
'final' config attributes
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46831/#review131088
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Квітень 29, 2016, 12:56 після полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46831/
> -----------------------------------------------------------
>
> (Updated Квітень 29, 2016, 12:56 після полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-16161
> https://issues.apache.org/jira/browse/AMBARI-16161
>
>
> Repository: ambari
>
>
> Description
> -------
>
> `takeover_config_merge.py` when parsing config files should capture the
> _final_ flag from the XML files and set them in the config attributes in
> generated blueprint. They can be specified in the blueprint as:
>
>
>
> "configuration-type" : {
> "properties_attributes": {
> "property-name1" : "property-value"
> },
> "properties": {
> "property-name2" : "property-value"
> }
> }
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/takeover_config_merge.py 8f11db4
>
> Diff: https://reviews.apache.org/r/46831/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>