[GitHub] [tvm] jcf94 edited a comment on pull request #7143: [AutoScheduler] Python based measure callbacks

[GitBox <gi...@apache.org>]

jcf94 edited a comment on pull request #7143:
URL: https://github.com/apache/tvm/pull/7143#issuecomment-750704577


   > > Actually we already have a `init_search_callbacks` in the constructor function of SearchPolicy which will be called before the search process. And we also have the `PreloadCustomSketchRule` in our dev repo ...
   > 
   > Yeah that's why I bring up this, but my point is these callbacks are C-based instead of Python so there are not that convenient for users to experiment.
   
   Oh, I find that comment: https://github.com/apache/tvm/pull/7132#discussion_r547936669
   I agree with your point.
   So seems we will need to:
   1. Add the `PreloadCustomSketchRule` which enables users to add their own custom sketches. (And that's what we have already planed long before but didn't take action to bring that here from our dev repo ....)
   2. Just like your have added a python based `MeasureCallback` here, we'd better add a python based `SearchCallback` for init_search_callbacks.
   3. Better re-arrange the `rules->push_back(.......)` part, maybe also move them to Python as a `InitSearchCallbak`.
   
   Also cc @merrymercy @antinucleon 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org