You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@graphar.apache.org by "Sober7135 (via GitHub)" <gi...@apache.org> on 2026/03/01 17:14:30 UTC
[PR] ci: run pull request CI on `ready_for_review` and draft PRs [incubator-graphar]
Sober7135 opened a new pull request, #896:
URL: https://github.com/apache/incubator-graphar/pull/896
<!--
Thanks for contributing to GraphAr.
If this is your first pull request you can find detailed information on [CONTRIBUTING.md](https://github.com/apache/graphar/blob/main/CONTRIBUTING.md)
The Apache GraphAr (incubating) community has restrictions on the naming of pr title. You can find instructions in
[CONTRIBUTING.md](https://github.com/apache/graphar/blob/main/CONTRIBUTING.md#title) too.
-->
### Reason for this PR
<!--
Why are you proposing this change? If this is already tracked in an issue, please link to the issue here.
Explaining clearly why this change is beneficial is important for the reviewers to understand the context.
-->
fix #893 and part of #686
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
1. fix #893: CI should run when a draft PR is promoted to `ready_for_review`
2. part of #686: CI should also be allowed to run on draft PRs
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
3. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Not yet. This PR is a test XD
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **BREAKING CHANGE: <description>** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either
(a) a security vulnerability,
(b) a bug that caused incorrect or invalid data to be produced, or
(c) a bug that causes a crash (even when the API contract is upheld).
We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **Critical Fix: <description>** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] ci: run pull request CI on `ready_for_review` and draft PRs [incubator-graphar]
Posted by "Sober7135 (via GitHub)" <gi...@apache.org>.
Sober7135 commented on PR #896:
URL: https://github.com/apache/incubator-graphar/pull/896#issuecomment-3982709642
> > emmm, it seems that marking PR as `ready_for_review` will retrigger CI. Maybe we should avoid this ? CC @yangxk1
>
> I think this is as expected
Maybe running CI for draft PRs is enough?
Currently, draft PRs are already allowed to run CI. However, when the author marks the PR as `ready_for_review`, CI is triggered again by the `ready_for_review` event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] ci: run pull request CI on `ready_for_review` and draft PRs [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #896:
URL: https://github.com/apache/incubator-graphar/pull/896#issuecomment-3982732882
Generally, draft should not execute ci. Running ci before is to expose ci failure in advance. Maybe we can **change it to the same as before**, that is, execute ci under draft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] ci: run pull request CI on `ready_for_review` and draft PRs [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #896:
URL: https://github.com/apache/incubator-graphar/pull/896#issuecomment-3981952237
> emmm, it seems that marking PR as `ready_for_review` will retrigger CI. Maybe we should avoid this ? CC @yangxk1
I think this is as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] ci: run pull request CI on `ready_for_review` and draft PRs [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 merged PR #896:
URL: https://github.com/apache/incubator-graphar/pull/896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] ci: run pull request CI on `ready_for_review` and draft PRs [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #896:
URL: https://github.com/apache/incubator-graphar/pull/896#issuecomment-3982743758
If there are changes after `ready_for_review`, I'm afraid it's not enough to just run it in draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] ci: run pull request CI on `ready_for_review` and draft PRs [incubator-graphar]
Posted by "Sober7135 (via GitHub)" <gi...@apache.org>.
Sober7135 commented on PR #896:
URL: https://github.com/apache/incubator-graphar/pull/896#issuecomment-3980572832
emmm, it seems that marking PR as `ready_for_review` will retrigger CI. Maybe we should avoid this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] ci: run pull request CI on `ready_for_review` and draft PRs [incubator-graphar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #896:
URL: https://github.com/apache/incubator-graphar/pull/896#issuecomment-3980553196
## [Codecov](https://app.codecov.io/gh/apache/incubator-graphar/pull/896?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.77%. Comparing base ([`d535a43`](https://app.codecov.io/gh/apache/incubator-graphar/commit/d535a437667c6e2bf28f7f376930b13ed5aed63d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51eaf70`](https://app.codecov.io/gh/apache/incubator-graphar/commit/51eaf703c68e5b4ebb8b16898d8f6a0ce6b4e275?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #896 +/- ##
============================================
- Coverage 79.81% 76.77% -3.04%
Complexity 615 615
============================================
Files 93 84 -9
Lines 10296 8897 -1399
Branches 1055 1055
============================================
- Hits 8218 6831 -1387
+ Misses 1838 1826 -12
Partials 240 240
```
| [Flag](https://app.codecov.io/gh/apache/incubator-graphar/pull/896/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [spark](https://app.codecov.io/gh/apache/incubator-graphar/pull/896/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.32% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-graphar/pull/896?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] ci: run pull request CI on `ready_for_review` and draft PRs [incubator-graphar]
Posted by "Sober7135 (via GitHub)" <gi...@apache.org>.
Sober7135 commented on code in PR #896:
URL: https://github.com/apache/incubator-graphar/pull/896#discussion_r2871164740
##########
.github/workflows/ci.yml:
##########
@@ -27,6 +27,11 @@ on:
- 'cpp/**'
- '.github/workflows/ci.yml'
pull_request:
+ types:
+ - opened
+ - synchronize
+ - reopened
+ - ready_for_review
Review Comment:
See [GitHub docs](https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request:~:text=By%20default%2C%20a%20workflow%20only%20runs%20when%20a%20pull_request%20event%27s%20activity%20type%20is%20opened%2C%20synchronize%2C%20or%20reopened.):
> By default, a workflow only runs when a `pull_request` event's activity type is `opened`, `synchronize`, or `reopened`.
So when a PR is updated (for example, new commits are pushed and the head branch is updated), CI will be triggered again by the `pull_request` event with the `synchronize` activity type. See [GitHub docs](https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request:~:text=workflow%27s%20repository%20occurs.-,For%20example%2C%20if%20no%20activity%20types%20are%20specified%2C%20the%20workflow%20runs%20when%20a%20pull%20request%20is%20opened%20or%20reopened%20or%20when%20the%20head%20branch%20of%20the%20pull%20request%20is%20updated.,-For%20activity%20related).
Given that, I think it is fine to remove the explicit `types` filter and rely on the defaults, unless we specifically want to also trigger CI on `ready_for_review`.
CC @yangxk1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org