[GitHub] [druid] maytasm commented on a change in pull request #12071: docs: remove maxRowsPerSegment where appropriate

[GitBox <gi...@apache.org>]

maytasm commented on a change in pull request #12071:
URL: https://github.com/apache/druid/pull/12071#discussion_r769136883



##########
File path: docs/design/coordinator.md
##########
@@ -107,7 +107,7 @@ need compaction or not.
 A set of segments need compaction if all conditions below are satisfied.
 
 1) Total size of segments in the time chunk is smaller than or equal to the configured `inputSegmentSizeBytes`.
-2) Segments have never been compacted yet or compaction spec has been updated since the last compaction, especially `maxRowsPerSegment`, `maxTotalRows`, and `indexSpec`.

Review comment:
       imho we can remove the especially part. I don't think those are any more special than the other specs in the compaction config.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org