You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/05/19 17:52:53 UTC
Re: Review Request 58358: Update vendored protobuf tar.gz to 3.3.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58358/
-----------------------------------------------------------
(Updated May 19, 2017, 5:52 p.m.)
Review request for mesos, Anand Mazumdar and Joseph Wu.
Changes
-------
Use 3.3.0 instead.
Summary (updated)
-----------------
Update vendored protobuf tar.gz to 3.3.0.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description (updated)
-------
The content of `3rdparty/protobuf-3.2.0.tar.gz` is generated by:
- On a Mac OS, download and untar protobuf v3.3.0 source at
https://github.com/google/protobuf/archive/v3.3.0.tar.gz;
- Run `./autogen.sh`;
- Recompress and tar by `tar -czvf`.
Diffs (updated)
-----
3rdparty/protobuf-2.6.1.tar.gz e1c2d541c1eb806e837ff5d1e9d3fdb678b40e06
3rdparty/protobuf-3.3.0.tar.gz PRE-CREATION
Diff: https://reviews.apache.org/r/58358/diff/6/
Changes: https://reviews.apache.org/r/58358/diff/5-6/
Testing
-------
1. make check;
2. used the modified `test-upgrade.py` in r/58357 to test upgrade/downgrade between this chain and Mesos 1.2;
3. build this branch in Apache Aurora's vagrant based box, and verifies that Aurora scheduler (using java) and executor (using python) still works with `libmesos.so` built from this branch.
Thanks,
Zhitao Li
Re: Review Request 58358: Update vendored protobuf tar.gz to 3.3.0.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58358/#review175551
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On May 19, 2017, 5:52 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58358/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 5:52 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Joseph Wu.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The content of `3rdparty/protobuf-3.2.0.tar.gz` is generated by:
> - On a Mac OS, download and untar protobuf v3.3.0 source at
> https://github.com/google/protobuf/archive/v3.3.0.tar.gz;
> - Run `./autogen.sh`;
> - Recompress and tar by `tar -czvf`.
>
>
> Diffs
> -----
>
> 3rdparty/protobuf-2.6.1.tar.gz e1c2d541c1eb806e837ff5d1e9d3fdb678b40e06
> 3rdparty/protobuf-3.3.0.tar.gz PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58358/diff/6/
>
>
> Testing
> -------
>
> 1. make check;
> 2. used the modified `test-upgrade.py` in r/58357 to test upgrade/downgrade between this chain and Mesos 1.2;
> 3. build this branch in Apache Aurora's vagrant based box, and verifies that Aurora scheduler (using java) and executor (using python) still works with `libmesos.so` built from this branch.
>
>
> Thanks,
>
> Zhitao Li
>
>